Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When enableMailSummaries is false in the configuration file, prevent accessing the "E-Mail Summaries" page in the account settings #6774

Closed
marc-farre opened this issue Dec 22, 2023 · 4 comments

Comments

@marc-farre
Copy link
Collaborator

What steps will reproduce the problem?

Disable E-Mail Summaries: https://docs.humhub.org/docs/admin/config-options/#activity -> 'enableMailSummaries' => false

Go to https://my-humhub.com/activity/user

What is the expected result?

404 not found

What do you get instead?

The page is displayed

Additional info

Original discussion: https://community.humhub.com/content/perma?id=273925

Q A
HumHub version 1.15.2
@marc-farre
Copy link
Collaborator Author

@luke- if the solution is only to throw a 404 error in the controller, I can send a PR for it.

@luke-
Copy link
Contributor

luke- commented Dec 22, 2023

@marc-farre Yes, in this case we should hide the navigation item in the user & admin area and a 404 is sufficient for the controller.

marc-farre added a commit that referenced this issue Dec 22, 2023
…e, prevent accessing the E-Mail Summaries page in the account settings
@marc-farre
Copy link
Collaborator Author

@luke- PR #6775
Menu was already OK

@luke-
Copy link
Contributor

luke- commented Dec 22, 2023

@marc-farre Thanks!

@luke- luke- closed this as completed Dec 22, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 22, 2023
…e, prevent accessing the E-Mail Summaries page in the account settings (#6775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants