Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UX for the maintenance mode administration form #6879

Closed
Gilbertdelyon opened this issue Mar 7, 2024 · 18 comments
Closed

Better UX for the maintenance mode administration form #6879

Gilbertdelyon opened this issue Mar 7, 2024 · 18 comments

Comments

@Gilbertdelyon
Copy link

When you put the site in maintenance mode you go to admin > setting > maintenance and there you can only select or unselect maintenance mode.

It would be nice to also have a text input area where you could enter a contextual message with probable duration of maintenance.

It's made this way in my other favorite CMS and it's very convenient.

@marc-farre
Copy link
Collaborator

It's already the case. Once "Enable maintenance mode" is checked, the message field becomes editable:

image

@ArchBlood
Copy link
Contributor

It's already the case. Once "Enable maintenance mode" is checked, the message field becomes editable:

image

Exactly so, although I'm not sure a lot of people understand that the checkbox field must be checked to use the text field, maybe we should add a hint for the checkbox after all.

@Gilbertdelyon
Copy link
Author

Gilbertdelyon commented Mar 8, 2024

Ah, I see :
I didn't see it because popup appears before, and once the popup is displayed you think that a click on "Activate" will put directly the site in maintenance mode.
So, I would suggest this way:

  • text input field is fillable in any case
  • popup will appear after you click the save button of the form, if the maintenance mode checkbox was modified.

@Gilbertdelyon
Copy link
Author

An other issue with the way it works is that once you click "Activate" in the popup you may think that the site is now in maintenance mode while it is not as long as you haven't saved the complete form.
I now realised that I made this mistake several times. Fortunately the sites I manage are not very busy.

@marc-farre
Copy link
Collaborator

marc-farre commented Mar 8, 2024

once you click "Activate" in the popup you may think that the site is now in maintenance mode

I agree, I've had admins report this issue to me too.

@luke- Suggestions summary:

  • Rename "Enable maintenance mode" to "Maintenance mode is enabled"
  • Remove the modal box and add the warning text in the form, or show this warning as a modal confirmation on form submit
  • Nether disable the "custom info text" field

image

image

@luke-
Copy link
Contributor

luke- commented Mar 8, 2024

@marc-farre Sounds good for me.

@Semir1212 Can you please check the texts?

@Semir1212
Copy link
Contributor

@marc-farre I'm not sure if I've understood your idea correctly, but I would do it this way:

  • Remove modal
  • Leave checkbox text as is
  • Add placeholder text into the input field "Add individual info text..."
  • Warning below the input field "Maintenance mode restricts access to the platform and immediately logs out all users except Admins."

What do you think about that?

@ArchBlood
Copy link
Contributor

@marc-farre I'm not sure if I've understood your idea correctly, but I would do it this way:

  • Remove modal
  • Leave checkbox text as is
  • Add placeholder text into the input field "Add individual info text..."
  • Warning below the input field "Maintenance mode restricts access to the platform and immediately logs out all users except Admins."

What do you think about that?

I can agree with this, of course with the confirmation notice before enabling maintenance mode, the issue here would be the save state and how @Gilbertdelyon describes how currently you must click the checkbox then the save button, I agree with the current method used, but I'm not opposed to making the checkbox and an auto save, the only issue would be also implementing the confirmation. modal

@Gilbertdelyon
Copy link
Author

Gilbertdelyon commented Mar 11, 2024

My 2 cents!
I would suggest:
Warning below the checkbox field:
"Maintenance mode will restricts access to the platform and immediately logs out all users except Admins."

Let the hint as it is below the text input field as it is now:
"Add custom info text for maintenance mode. Displayed on the login page."

@Gilbertdelyon
Copy link
Author

An other usefull thing I would suggest:
When the site is in Maintenance Mode (MM) if you visit it as admin there is no sign that MM is active. So you may forget to unset the MM.
Would it be a pain to add a warning somewhere in the top bar or sidebar?

@ArchBlood
Copy link
Contributor

An other usefull thing I would suggest: When the site is in Maintenance Mode (MM) if you visit it as admin there is no sign that MM is active. So you may forget to unset the MM. Would it be a pain to add a warning somewhere in the top bar or sidebar?

As an admin you should see this in the sidebar;
Screenshot_1

@Gilbertdelyon
Copy link
Author

Gilbertdelyon commented Mar 11, 2024

Oops! You are right. Sorry.

@marc-farre
Copy link
Collaborator

@Semir1212 thanks for this summary:

  • Remove modal
  • Leave checkbox text as is
  • Add placeholder text into the input field "Add individual info text..."
  • Warning below the input field "Maintenance mode restricts access to the platform and immediately logs out all users except Admins."

That's fine.
Maybe we could also rename the checkbox "Enable maintenance mode" to "Maintenance mode is enabled".

Also, it's important not to disable the input field when the checkbox is unchecked:
image

And as @Gilbertdelyon suggests, the warning message should be under the checkbox and not the input field:
image

The maintenance mode warning on the sidebar could be a separated issue I think.

@Gilbertdelyon
Copy link
Author

The maintenance mode warning on the sidebar could be a separated issue I think.

In fact I made mistake. The maintenance mode in the sidebar is already existing. Sorry

@Semir1212
Copy link
Contributor

@marc-farre I would leave the checkbox text for now as the style somewhat aligns with other checkboxes. We are also currently working on a few improvements regarding the wording.

Rest is fine with me.

@marc-farre
Copy link
Collaborator

marc-farre commented Mar 13, 2024

@marc-farre I would leave the checkbox text for now as the style somewhat aligns with other checkboxes. We are also currently working on a few improvements regarding the wording.

Rest is fine with me.

@Semir1212 Fine. Thanks!

PS: About "the warning message should be under the checkbox", I was thinking about an attribute hint of the checkbox, so no custom style.

@Gilbertdelyon
Copy link
Author

Another "small" issue with maintenance mode.
As soon as maintenance mode is active I get this error in console:
image

@marc-farre marc-farre changed the title Maintenance mode message should be editable easily Better UX for the maintenance mode administration form Apr 2, 2024
@marc-farre
Copy link
Collaborator

@luke- PR #6910

@Semir1212

image

image

github-merge-queue bot pushed a commit that referenced this issue Apr 4, 2024
)

Co-authored-by: Lucas Bartholemy <luke-@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants