Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default stream sort by created_at instead of id #5315

Merged
merged 17 commits into from Aug 17, 2023
Merged

Default stream sort by created_at instead of id #5315

merged 17 commits into from Aug 17, 2023

Conversation

luke-
Copy link
Contributor

@luke- luke- commented Sep 28, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • When resolving a specific issue, it's referenced in the PR's description (e.g. Fix #xxx[,#xxx], where "xxx" is the Github issue number)
  • All tests are passing
  • New/updated tests are included
  • Changelog was modified

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@luke- luke- changed the base branch from master to develop September 28, 2021 16:29
@luke- luke- changed the title Stream Sort Default stream sort by created_at instead of id Sep 29, 2021
# Conflicts:
#	protected/humhub/modules/content/tests/codeception/fixtures/data/content.php
#	protected/humhub/modules/stream/models/StreamQuery.php
@yurabakhtin yurabakhtin changed the base branch from develop to master May 22, 2023 12:10
Copy link
Contributor Author

@luke- luke- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurabakhtin Can we please base this PR into develop. I think this change is too critical for a minor release.

@yurabakhtin yurabakhtin changed the base branch from master to develop May 23, 2023 05:45
# Conflicts:
#	protected/humhub/config/common.php
# Conflicts:
#	protected/humhub/config/common.php
@yurabakhtin
Copy link
Contributor

@yurabakhtin Can we please base this PR into develop. I think this change is too critical for a minor release.

@luke- Ok, done.

@luke-
Copy link
Contributor Author

luke- commented May 23, 2023

@yurabakhtin Thanks, can you please take a look into the tests?

@luke- luke- added this to the v1.16 milestone Aug 17, 2023
@luke- luke- changed the base branch from develop to next August 17, 2023 18:24
@luke- luke- merged commit 89997ef into next Aug 17, 2023
6 checks passed
@luke- luke- deleted the enh/streamsort branch November 25, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants