Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link notification for pending space approval to manage page #6420

Merged
merged 7 commits into from
Jul 12, 2023

Conversation

felixhahnweilheim
Copy link
Contributor

@felixhahnweilheim felixhahnweilheim commented Jul 10, 2023

What kind of change does this PR introduce? (check at least one)

  • Bugfix (esp. for mobile view)
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • When resolving a specific issue, it's referenced in the PR's description (e.g. Fix #xxx[,#xxx], where "xxx" is the Github issue number)
  • All tests are passing
  • New/updated tests are included
  • Changelog was modified

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
PR for #6395

@felixhahnweilheim
Copy link
Contributor Author

I was able to fix 1 of 2 tests. But I am not sure what is the problem with the other one. Maybe someone can help with this?

@luke-
Copy link
Contributor

luke- commented Jul 10, 2023

@gevorgmansuryan Can you please help?

@felixhahnweilheim
Copy link
Contributor Author

Yes, I've solved it!

(It seems for the "click" in tests, you have to add the context (e.g. '.grid-view') and not the item itself ('.grid-view .btn').)

@luke- luke- added this pull request to the merge queue Jul 12, 2023
Merged via the queue into humhub:develop with commit 5197e62 Jul 12, 2023
6 checks passed
@felixhahnweilheim felixhahnweilheim deleted the patch-2 branch July 12, 2023 13:08
martin-rueegg added a commit to metaworx/humhub that referenced this pull request Aug 11, 2023
martin-rueegg added a commit to metaworx/humhub that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants