Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module form "Set as default" #6494

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Fix module form "Set as default" #6494

merged 3 commits into from
Aug 10, 2023

Conversation

yurabakhtin
Copy link
Contributor

@yurabakhtin yurabakhtin commented Aug 9, 2023 •
edited

What kind of change does this PR introduce? (check at least one)

  • Bugfix

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • All tests are passing
  • Changelog was modified

Other information:
Issue: #6492

@yurabakhtin yurabakhtin requested a review from luke- August 9, 2023 13:48
@yurabakhtin yurabakhtin mentioned this pull request Aug 9, 2023
Closed
@luke- luke- added this pull request to the merge queue Aug 10, 2023
Merged via the queue into develop with commit 64a5099 Aug 10, 2023
6 checks passed
@yurabakhtin yurabakhtin mentioned this pull request Aug 11, 2023
Merged
4 tasks
@yurabakhtin
Copy link
Contributor Author

@luke- In this PR here https://github.com/humhub/humhub/pull/6494/files#diff-207bc2d8805fbf0385997b7ce13add586b6106038a1a47c455c74f1ccae3478dR104 I wanted to improve the code js function client.submit(event) but today I detected that form POST data is not passed when it is submitted from modal window (e.g. add new user to mail conversation), so I decided to revert that my change in new PR #6501, please merge this, thanks.

@luke- luke- deleted the fix/6492-set-as-default-module branch August 11, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luke- luke- luke- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yurabakhtin @luke-