Enh: Apply UUID validator #6587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-rueegg
force-pushed
the
enh/improve-uuid-validator-2
branch
from
1efad91
to
9d901fc
Compare
5 tasks
martin-rueegg
force-pushed
the
enh/improve-uuid-validator-2
branch
2 times, most recently
from
b101036
to
fc8644b
Compare
14 tasks
martin-rueegg
force-pushed
the
enh/improve-uuid-validator-2
branch
from
fc8644b
to
400b1f5
Compare
6 tasks
luke-
requested changes
Dec 7, 2023
There was a problem hiding this comment.
@martin-rueegg Thanks for the contribution. Please see my remarks below.
protected/humhub/modules/content/components/ContentContainerActiveRecord.php
Outdated
Show resolved
Hide resolved
luke-
requested changes
Dec 7, 2023
protected/humhub/modules/content/components/ContentContainerActiveRecord.php
Outdated
Show resolved
Hide resolved
martin-rueegg
force-pushed
the
enh/improve-uuid-validator-2
branch
from
86fc95c
to
a156efd
Compare
martin-rueegg
force-pushed
the
enh/improve-uuid-validator-2
branch
2 times, most recently
from
2d958dd
to
b75300a
Compare
luke-
approved these changes
Dec 11, 2023
martin-rueegg
force-pushed
the
enh/improve-uuid-validator-2
branch
4 times, most recently
from
5f513e6
to
de27e12
Compare
martin-rueegg
force-pushed
the
enh/improve-uuid-validator-2
branch
from
de27e12
to
0bee9a5
Compare
luke-
requested changes
Dec 15, 2023
martin-rueegg
force-pushed
the
enh/improve-uuid-validator-2
branch
from
0bee9a5
to
5223a33
Compare
luke-
approved these changes
Dec 15, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
UUID (e.g. used in
guidcolumns) must actually be valid UUIDs, meaningApplied to
contentcontainer.guidcontent.guidfile.guidspace.guiduser.guidThe PR fulfills these requirements
nextbranch, not themasterbranch if no hotfixFix #xxx[,#xxx], where "xxx" is the Github issue number)If adding a new feature, the PR's description includes:
Other information: