Fix MigrateController::$migrationPathMap
#6693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-
approved these changes
Dec 7, 2023
auto-merge was automatically disabled
December 7, 2023 22:27
Head branch was pushed to by a user without write access
martin-rueegg
force-pushed
the
fix/migration-map
branch
from
2696548
to
d26edcf
Compare
|
Sorry, by rebasing to resolve the conflict, I've disabled auto-merge ... |
luke-
approved these changes
Dec 8, 2023
martin-rueegg
added a commit
to metaworx/humhub
that referenced
this pull request
Dec 11, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MigrateController::$migrationPathMapwould store the sum of the migrations encountered so far while collecting the migrations of the different migration paths. This makes no sense at all. :-)This PR fixes that only the migrations of a given
$pathare stored underMigrateController::$migrationPathMap[$path].In addition, type cleanup is applied.
PR Admin
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
If yes, please describe the impact and migration path for existing applications:
Type restrictions as documented in
MIGRATE-DEV.md. However, there's no inheritance of the class in the core and unlikely in modules. So risk is low.The PR fulfills these requirements:
developbranch, not themasterbranch if no hotfix