New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh: run migrations manually #6711
Conversation
All failing tests have to do with
I have no clue how this could be related to the changes in this PR. |
@luke- Could that have to do with your merges from master to develop? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martin-rueegg Thanks, below my review.
protected/humhub/modules/admin/controllers/InformationController.php
Outdated
Show resolved
Hide resolved
protected/humhub/modules/admin/controllers/InformationController.php
Outdated
Show resolved
Hide resolved
protected/humhub/modules/admin/controllers/InformationController.php
Outdated
Show resolved
Hide resolved
protected/humhub/modules/admin/controllers/InformationController.php
Outdated
Show resolved
Hide resolved
protected/humhub/modules/admin/controllers/InformationController.php
Outdated
Show resolved
Hide resolved
ac7700a
to
a240d54
Compare
protected/humhub/modules/admin/controllers/InformationController.php
Outdated
Show resolved
Hide resolved
protected/humhub/modules/admin/controllers/InformationController.php
Outdated
Show resolved
Hide resolved
a240d54
to
7760213
Compare
protected/humhub/modules/admin/controllers/InformationController.php
Outdated
Show resolved
Hide resolved
@luke- Thank you for the review. I hope I have now been able to adjust accordingly. |
99d38c3
to
fbbc29c
Compare
22880bf
to
fbbc29c
Compare
protected/humhub/modules/admin/controllers/InformationController.php
Outdated
Show resolved
Hide resolved
fbbc29c
to
e8bb6d6
Compare
@luke- @martin-rueegg Probably the bug is related somehow: |
@yurabakhtin would you be able to describe the procedure? Does the "not secure" info in the addressbar show up before or after you click "Update Database"? I'd suggest that the problem may be a http vs https incongruency. |
@martin-rueegg I just started to work on new branch https://github.com/humhub/humhub/tree/enh/search where we have new migration
My local test server works on I can reproduce the broken layout even with simple opening the url like |
Ah, I see. So I guess it has nothing to do with the "not secure" warning. I can't reproduce it here with https. And when I use http, it automatically switches to https (browser and server side). So I'd have to change my setup. But you could print a screenshot of the requests sent (visible in the network tab of the developer console of the browser). I'm sure there are some css (and maybe other) files that are not correctly loaded. |
strange why the files are not loaded, but if I copy their url into a new browser tab, I see the files are loaded correctly:
I see only one difference in the param I have this bug in Chrome and FireFox browsers. The branch |
@yurabakhtin This is indeed very peculiar. Would you mind pasting the source code of the two main pages here? I.e. the raw response from the following requests:
And do you have a chance to see if the requests actually hit the webserver? |
@martin-rueegg I have detected the problem was in the code After fix for me it looks like this: |
Thank you, @yurabakhtin. See my further comments in the respective PR. |
Currently, when navigating to Administration -> Information -> Database, any pending migration is applied immediately and leaves the administrator no choice of whether to actually apply them now.
PR Admin
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements
develop
branch, not themaster
branch if no hotfix