Enh: Consolidate (is|set)(Database)Installed() to ApplicationTrait
#6720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-rueegg
changed the title
isInstalled(), setInstalled(), and setDatabaseInstalled()
|
All failing errors seem to stem from |
luke-
requested changes
Dec 10, 2023
martin-rueegg
force-pushed
the
enh/consolidate-isInstalles-idDatabaseInstalled
branch
from
4670cac
to
d27dc28
Compare
martin-rueegg
changed the title
isInstalled(), setInstalled(), and setDatabaseInstalled()(is|set)(Database)Installed() to ApplicationTrait
martin-rueegg
force-pushed
the
enh/consolidate-isInstalles-idDatabaseInstalled
branch
from
d27dc28
to
fa1fe03
Compare
martin-rueegg
force-pushed
the
enh/consolidate-isInstalles-idDatabaseInstalled
branch
from
fa1fe03
to
579d1c3
Compare
luke-
approved these changes
Dec 11, 2023
|
@martin-rueegg It's much better that way! Thanks for the refactoring! |
martin-rueegg
deleted the
enh/consolidate-isInstalles-idDatabaseInstalled
branch
martin-rueegg
added a commit
to metaworx/humhub
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings, that has nothing to do withSettingsBaseSettingsManagerwhere alsoisDatabaseInstalled()residesWhat kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements
developbranch, not themasterbranch if no hotfixOther information: