Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sending a notification to originator when sending to a single u… #6752

Merged
merged 2 commits into from Dec 18, 2023

Conversation

marc-farre
Copy link
Collaborator

Allow sending a notification to originator when sending to a single user and suppressSendToOriginator is false

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • When resolving a specific issue, it's referenced in the PR's description (e.g. Fix #xxx[,#xxx], where "xxx" is the Github issue number)
  • All tests are passing
  • New/updated tests are included
  • Changelog was modified

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@marc-farre
Copy link
Collaborator Author

@luke- suppressSendToOriginator was working when sending with ->sendBlulk() but not with ->send().

@luke- luke- added this pull request to the merge queue Dec 18, 2023
@luke-
Copy link
Contributor

luke- commented Dec 18, 2023

@marc-farre Thanks for the fix!

Merged via the queue into develop with commit 434318b Dec 18, 2023
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants