Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/return value of group add user #6875

Merged
merged 3 commits into from Mar 6, 2024
Merged

Conversation

marc-farre
Copy link
Collaborator

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • When resolving a specific issue, it's referenced in the PR's description (e.g. Fix #xxx[,#xxx], where "xxx" is the Github issue number)
  • All tests are passing
  • New/updated tests are included
  • Changelog was modified

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

…le command or user registration), the method returns false even if the user was added to the group
…le command or user registration), the method returns false even if the user was added to the group
Copy link

what-the-diff bot commented Mar 6, 2024

PR Summary

  • Fixes issue Fix/return value of group add user #6875 related to user group addition
    The updates in this Pull Request address a challenge where the method of adding a user into a group was giving incorrect feedback. Specifically, even when the user was successfully introduced, it was reporting a failure if the current user was not logged in. The implemented fix rectifies the issue by checking if the user is a guest before generating a response.

  • Notification improvements for guest users
    An adjustment has been made to the method of adding users into groups. The change ensures that notifications are not sent out unnecessarily when the individual added to the group is a guest. This results in a more efficient and less intrusive notification system.

  • Code style enhancement within the group user approval notification
    There's been a subtle but crucial enhancement regarding the formatting of the code. Specifically, the indentation within the translation strings has been aligned in order to adhere to the overall style of the project's coding. This improves readability and maintains code consistency throughout the project.

@marc-farre
Copy link
Collaborator Author

@luke- small fix:

On Group::addUser(), if the current user is not logged in (console command or user registration), the method returns false even if the user was added to the group

@luke- luke- added this pull request to the merge queue Mar 6, 2024
Merged via the queue into develop with commit e430fcd Mar 6, 2024
6 checks passed
@luke- luke- deleted the fix/return-value-of-group-add-user branch March 6, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants