Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new method getCommentUrl for permanent comment URL #6892

Merged
merged 1 commit into from Mar 18, 2024

Conversation

yurabakhtin
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Feature

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • All tests are passing
  • Changelog was modified

Other information:
Issue: https://github.com/humhub/humhub-internal/issues/174

@yurabakhtin yurabakhtin requested a review from luke- March 18, 2024 10:16
Copy link

what-the-diff bot commented Mar 18, 2024

PR Summary

  • Improved the methodology in getCommentUrl functionality
    The getCommentUrl method, designed to provide a long-lasting URL for comments, has been improved in its execution for better results.

  • Additional statement in PermaController.php for error handling
    A use statement for yii\web\BadRequestHttpException has been included. This addition will enhance error notifications and handling when encountering challenges during operations.

  • Advancements made to comment redirection logic
    Alterations have been made to how users are redirected to the comment's URL. This reworking aims to provide an optimized and more user-friendly redirection process.

  • Added validation for content URL existence
    Validation has been integrated into the system such that errors will be thrown whenever the content lacks a URL for individuals to place their comments.

@luke- luke- added this pull request to the merge queue Mar 18, 2024
Merged via the queue into develop with commit 585d106 Mar 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants