Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh #6950: Ability to reset some notification settings to all users w… #6964

Merged

Conversation

marc-farre
Copy link
Collaborator

…ithout resetting "Like" notifications by email

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • When resolving a specific issue, it's referenced in the PR's description (e.g. Fix #xxx[,#xxx], where "xxx" is the Github issue number)
  • All tests are passing
  • New/updated tests are included
  • Changelog was modified

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Issue #6950

…ithout resetting "Like" notifications by email
Copy link

what-the-diff bot commented Apr 22, 2024

PR Summary

  • Improved Search Experience on Mobile
    A fix has been added that enhances the visibility of the search feature on mobile devices by ensuring it stays within the viewport.

  • Refined Notification Reset Functionality
    We have incorporated an enhancement that allows you to reset notification settings for all users, excluding the "Like" notifications sent via email. This gives you more control over managing user settings.

  • Adjustments in the NotificationManager Class

    • A new indicator IS_TOUCHED_SETTINGS has been introduced, serving as a marker for touched settings.
    • A new method isTouchedSettings has been introduced that checks whether a setting has been modified.
    • Multiple existing methods like getSpaces, setDesktopNotificationSettings, isUntouchedSettings, and resetSpaces have also been updated to align with these changes.
  • New Migration File For Untouched Settings
    The migration file m240422_162959_new_is_untouched_settings has been added to handle database changes related to untouched settings.

  • Updates in the NotificationSettings Model

    • A new method isTouchedSettings has been added to check if settings have been modified.
    • Several methods like save, resetUserSettings, and resetAllUserSettings have been altered to accommodate the new features.
  • Revised notification.php View File
    We made necessary modifications to the notification.php view file to ensure seamless incorporation of the new enhancements.

Copy link
Contributor

@luke- luke- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc-farre Thanks, looks fine for me. Can you please modifiy the migration as suggested?

@luke- luke- added this pull request to the merge queue Apr 24, 2024
Merged via the queue into develop with commit 2738f80 Apr 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants