Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init of ContentHighlightAsset #7003

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

yurabakhtin
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • All tests are passing
  • Changelog was modified

Other information:
https://github.com/humhub/humhub-internal/issues/89#issuecomment-2110317971
#6971

@yurabakhtin yurabakhtin requested a review from luke- May 15, 2024 15:53
Copy link

what-the-diff bot commented May 15, 2024

PR Summary

  • Dependency Added to ContentAsset
    Our software now contains a new dependency within 'ContentAsset'. The humhub\modules\content\assets\ContentHighlightAsset has been added, allowing for better interaction between different parts of the project.

  • Change in ContentHighlightAsset Registration
    Previously, the practice was to register humhub\modules\content\assets\ContentHighlightAsset from within 'Events::onViewBeginBody'. This step has been eradicated to streamline the process.

  • Addition of 'init' method in ContentHighlightAsset
    The ContentHighlightAsset::init method has been integrated, providing us the ability to register the content.highlight JS config. This means it's easier for the software to know how to work with content.highlight data.

  • Removal of the Begin Body Event Registration
    The registration of View::EVENT_BEGIN_BODY event via Events::onViewBeginBody in config.php was removed. This change contributes to simplifying the workflow by eliminating unnecessary processes.

@luke-
Copy link
Contributor

luke- commented May 15, 2024

@yurabakhtin Can you please check the tests?

@luke-
Copy link
Contributor

luke- commented May 16, 2024

@yurabakhtin hm, still something broken :-)

@yurabakhtin
Copy link
Contributor Author

@luke- Now it is fixed.

@luke- luke- added this pull request to the merge queue May 16, 2024
Merged via the queue into develop with commit a405027 May 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants