MigrationFailed on develop

[luke-]

Seems the recently introduce MigrateService is breaking the REST Tests:
humhub/humhub@4d142b0

See: https://github.com/humhub/rest/actions/runs/7235023663/job/19711995483

Also related to modules:
https://github.com/humhub/tasks/actions/runs/7287917971/job/19859512684

[luke-]

@martin-rueegg Any idea?

[martin-rueegg]

Is it normal that the installation of the module has this Ø sign?

The test in the tasks module does not have that. Are you sure it is related?

[martin-rueegg]

@luke- how would I run those tests locally? Would I need to install the REST module?

[luke-]

The Checkout Rest Module Steps are required for modules, which implement an own REST API e.g. for tasks Module. The rest module itself doesn't need this. So these steps are skipped here.

---

I expect that the tests from the REST module can be executed like other tests.

The REST Module Tests seems to failing with:

So my first guess where the recent develop MigrationService changes.

---

If you want to execute the REST Tests of e.g. the tasks module, some additional steps are neccessary.
e.g. https://github.com/humhub/actions/blob/main/.github/workflows/module-tests-develop.yml#L152

[martin-rueegg]

It may be related to https://github.com/humhub/humhub/pull/6511/files#diff-46a3b644fa0848e9b9ff89b55e78b267182b69d39cea2f61870c54d37d0a78a5R413-R422

At least, that's another issue. Because if I search for "REST" in the marketplace (on my local installation) it fails.

[martin-rueegg]

Installation of the REST API module works locally. But then activation fails with the same error as in the test:

Invalid Configuration – [yii\base\InvalidConfigException](https://www.yiiframework.com/doc-2.0/yii-base-invalidconfigexception.html)
Migration failed!

    1. in /shared/httpd/humhub/htdocs/protected/humhub/services/MigrationService.php at line 265
    256257258259260261262263264265266267268269270271272273274

            }
     
            $this->trigger(self::EVENT_AFTER_MIGRATION, $result);
     
            /** @see \yii\console\controllers\BaseMigrateController::actionUp() */
            if ($result->result > ExitCode::OK) {
                $errorMessage = "Migration failed!";
     
                if (YII_DEBUG) {
                    throw new InvalidConfigException($errorMessage);
                }
     
                Yii::error($errorMessage, $this->module->id);
     
                return false;
            }
     
            return true;
        }

[martin-rueegg]

@luke- I might have found something in the MigrateController. But again, that's not the main issue here.

The following line causes an exception during migration:

rest/migrations/m230401_174208_add_allow_jwt_auth.php

Line 13 in 1c65540

$module->settings->set('enableJwtAuth', !empty($module->settings->get('jwtKey')));

Exception: Trying to get property 'settings' of non-object

which kinda makes sense since the module is not yet enabled:

rest/migrations/m230401_174208_add_allow_jwt_auth.php

Line 11 in 1c65540

$module = Yii::$app->getModule('rest');

I guess this has to do with

• Enh improve module migrations humhub#6550 (comment)
• https://github.com/humhub/humhub/pull/6550/files#diff-f554620e3cd56e98b02b48ec23ddf7988bff8a5eebceb5785a963a5473300e0cR246-R262

As previously, the module was temporarily "enabled" (for the Yii:$app->getModule() and the Yii::$app->moduleManager) and then disabled again. So this made the module available during migration.

So we should either

• revert and enable the module first and disable it again upon migration errors
• or adapt migrations accordingly.

[martin-rueegg]

Does not solve the problem yet, but improves error message:

• Fix: Improve migration error messages humhub#6770

Further adjustments possible as per my previous comment.

[luke-]

@martin-rueegg Thank you for your investigation.

For now, I have reintroduced the ModuleManager::disable() in case of error as you originally suggested.
humhub/humhub@7cd97f0

Background for Hotfix: All module tests run automatically at the weekend and I want to see whether develop is green now.