Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improve migration error messages #6770

Merged
merged 5 commits into from Jan 22, 2024

Conversation

martin-rueegg
Copy link
Contributor

@martin-rueegg martin-rueegg commented Dec 21, 2023

PR Admin

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements

  • It's submitted to the develop branch, not the master branch if no hotfix
  • When resolving a specific issue, it's referenced in the PR's description (e.g. Fix #xxx[,#xxx], where "xxx" is the Github issue number)
  • All tests tests are passing
  • New/updated tests are included
  • Changelog was modified

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Related

@luke-
Copy link
Contributor

luke- commented Dec 22, 2023

@martin-rueegg Thanks. Any idea why the tests are failing?

@martin-rueegg
Copy link
Contributor Author

@martin-rueegg Thanks. Any idea why the tests are failing?

It is just one test: installing a module with migration. I need to look into it. Not sure I manage today though.

@luke-
Copy link
Contributor

luke- commented Dec 22, 2023

@martin-rueegg Thanks. Any idea why the tests are failing?

It is just one test: installing a module with migration. I need to look into it. Not sure I manage today though.

Thank you, absolutely no hurry.

@luke- luke- enabled auto-merge January 19, 2024 11:43
# Conflicts:
#	CHANGELOG-DEV.md
auto-merge was automatically disabled January 20, 2024 09:30

Head branch was pushed to by a user without write access

@martin-rueegg
Copy link
Contributor Author

@luke- I tried to merge develop, rather than to rebase. But still, Auto-merge has been disabled ...

@luke- luke- added this pull request to the merge queue Jan 22, 2024
@luke-
Copy link
Contributor

luke- commented Jan 22, 2024

@luke- I tried to merge develop, rather than to rebase. But still, Auto-merge has been disabled ...

Now it's working. Thank you!

Merged via the queue into humhub:develop with commit 4a01043 Jan 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants