feat: Add TopologySpreadConstraints support to the humiocluster CRD #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves the static affinity to values.yaml as the default to avoid breakage and correctly combines the requirements so arm64 and ppc nodes can not be selected.
ryanfaircloth
force-pushed
the
feat-topospread
branch
from
5f6d271
to
55f1779
Compare
Update ci.yaml Update ci.yaml
ryanfaircloth
force-pushed
the
feat-topospread
branch
from
55f1779
to
77be82a
Compare
This PR fixes humio#342 with the addition of TopologySpreadConstraints to the CR. Node instances of operator deployed by helm will not automatically update the CR for those instances the CR must be applied manually
ryanfaircloth
force-pushed
the
feat-topospread
branch
from
92283ad
to
1c25d7c
Compare
|
There are a number of changes in this PR that are not relevant to TopologySpreadConstraints, so it makes it hard to review. Additionally I think we'd want a simple test in https://github.com/humio/humio-operator/blob/master/controllers/suite/clusters/humiocluster_controller_test.go that tests these being added. Something similar to https://github.com/humio/humio-operator/blob/master/controllers/suite/clusters/humiocluster_controller_test.go#L4039 should work. |
|
Closing in favor of #670. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #342 with the addition of TopologySpreadConstraints to the CR. Node instances of operator deployed by helm will not automatically update the CR for those instances the CR must be applied manually