Remove the Watchlists model #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuckChorris
force-pushed
the
fuck-watchlists
branch
from
8004d68
to
1c902d5
Compare
| @@ -33,6 +33,14 @@ class LibraryEntry < ActiveRecord::Base | |||
| VALID_STATUSES = ["Currently Watching", "Plan to Watch", "Completed", "On Hold", "Dropped"] | |||
| validates :status, inclusion: {in: VALID_STATUSES} | |||
|
|
|||
| SNAKE_PARAMETERS = { | |||
There was a problem hiding this comment.
I don't like this constant name because it don't relate to the hash content. maybe something like SNAKE_STATUSES or STATUSES_HASH?
There was a problem hiding this comment.
I can agree with that, I kind of halfassed the naming. Will fix in morning.
|
Nice refactor! It's much more understandable now :) |
NuckChorris
force-pushed
the
fuck-watchlists
branch
from
1c902d5
to
075ab5b
Compare
|
💯 LGTM |
NuckChorris
added a commit
that referenced
this pull request
Aug 9, 2015
Remove the Watchlists model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been a lot of legacy crap using the Watchlists model, which for some damn reason never got properly torn out. This tears it out.
Oh and it also adds a way for MessageFormatter to extract mentioned users, which I'll be implementing as part of my feed refactoring ;)