Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBRequest as a struct #10

Merged
merged 2 commits into from Sep 18, 2021
Merged

HBRequest as a struct #10

merged 2 commits into from Sep 18, 2021

Conversation

adam-fowler
Copy link
Member

HBRequest being a struct affects Auth package considerably.
As Auth changes the request ie caching logged in entities on the request it cannot do this via a separate object anymore.
This means the auth apis are now at the the HBRequest level and some are mutating (login/logout).

HBRequest.auth.login is now HBRequest.authLogin
HBRequest.auth.logout is now HBRequest.authLogout

I have replicated this change across all the Auth apis

request.auth.login becomes request.authLogin and is also mutating
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #10 (d313176) into main (34e98d0) will decrease coverage by 0.90%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   84.43%   83.52%   -0.91%     
==========================================
  Files           7        7              
  Lines         167      170       +3     
==========================================
+ Hits          141      142       +1     
- Misses         26       28       +2     
Impacted Files Coverage Δ
...s/HummingbirdAuth/Authenticator/Request+Auth.swift 70.00% <70.00%> (-7.78%) ⬇️
.../HummingbirdAuth/Authenticator/Authenticator.swift 100.00% <100.00%> (ø)
Sources/HummingbirdAuth/BasicAuthentication.swift 100.00% <100.00%> (ø)
Sources/HummingbirdAuth/BearerAuthentication.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28af1de...d313176. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant