Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary writeHTTPParts allocation #30

Merged
merged 3 commits into from Nov 11, 2021

Conversation

adam-fowler
Copy link
Member

Don't use result from writeAndFlush so don't create promise for it. Return static successful void future

Don't use result from writeAndFlush so don't create promise for it. Return static successful void future
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #30 (ab12c64) into main (6795503) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   82.53%   82.72%   +0.18%     
==========================================
  Files          19       19              
  Lines         733      735       +2     
==========================================
+ Hits          605      608       +3     
+ Misses        128      127       -1     
Impacted Files Coverage Δ
...ces/HummingbirdCore/Server/HTTPServerHandler.swift 84.61% <100.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6795503...ab12c64. Read the comment docs.

@adam-fowler adam-fowler merged commit 1f42ef2 into main Nov 11, 2021
@adam-fowler adam-fowler deleted the write-http-parts-allocation branch November 11, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant