Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 2.x.x into main #14

Merged
merged 9 commits into from
Mar 8, 2024
Merged

Merge 2.x.x into main #14

merged 9 commits into from
Mar 8, 2024

Conversation

adam-fowler
Copy link
Member

No description provided.

* Async redis

* Add 2.x.x branch to CI

* Use pollTime from configuration

* Fix up tests after Hummingbird changes

* fix CI

* fix compile error

* new expectation code available in 5.9

* Extend RedisConnectionPoolService

* HBRedisConnectionPoolService

* Added expectedFulfillmentCount

* Updates based off PR comments

* Fix tests compiling after HB updates
* Updates for changes to job queue system

* Add timeout minutes to CI jobs

* Use gracefulShutdown()

* Add testMultipleJobQueueHandlers

* Update Package.swift

* Changes from project template

* Swift format
* Refactor of job queue

* Use 2.x.x-jobs-refactor branch

* Revert HummingbirdRedisJobsTests.wait change

* Fix comment

* Update testJobQueue

* Replace Data with ByteBuffer in JobsQueue

* Changes for HummingbirdTesting
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 78.21229% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 70.64%. Comparing base (8ecd89a) to head (2efeb21).

Files Patch % Lines
.../HummingbirdRedis/RedisConnectionPoolService.swift 47.50% 21 Missing ⚠️
Sources/HummingbirdJobsRedis/RedisJobQueue.swift 84.68% 17 Missing ⚠️
Sources/HummingbirdRedis/Redis+Codable.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   69.56%   70.64%   +1.07%     
==========================================
  Files           9        6       -3     
  Lines         437      310     -127     
==========================================
- Hits          304      219      -85     
+ Misses        133       91      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-fowler adam-fowler merged commit c5feabb into main Mar 8, 2024
7 of 8 checks passed
@adam-fowler adam-fowler deleted the 2.x.x branch March 8, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant