Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the masking key creation not generating 0x00 #16

Merged
merged 1 commit into from Apr 4, 2023

Conversation

Joannis
Copy link
Contributor

@Joannis Joannis commented Apr 4, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3e2e43a) 81.66% compared to head (84e0b89) 81.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   81.66%   81.66%           
=======================================
  Files           9        9           
  Lines         529      529           
=======================================
  Hits          432      432           
  Misses         97       97           
Impacted Files Coverage Δ
Sources/HummingbirdWSCore/WebSocket.swift 79.24% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adam-fowler
Copy link
Member

testImmediateWrite fails occasionally. I haven't got around to looking at why this occurs yet

@adam-fowler adam-fowler merged commit 0df9644 into hummingbird-project:main Apr 4, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants