Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ServiceLifecycle dependency #56

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

tkrajacic
Copy link
Contributor

We need to be explicit about dependencies we use.

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.28%. Comparing base (397f41e) to head (b610e39).
Report is 25 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #56       +/-   ##
===========================================
- Coverage   85.92%   71.28%   -14.65%     
===========================================
  Files          11       24       +13     
  Lines         995     1508      +513     
===========================================
+ Hits          855     1075      +220     
- Misses        140      433      +293     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Thomas

@adam-fowler adam-fowler merged commit 442a272 into hummingbird-project:main Apr 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants