Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min frame to compress config/fix closing bug #57

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

adam-fowler
Copy link
Member

These two are combined as the test for the min frame to compress revealed the close issue

  • Added new config value which defines the minimum size of frame before running compression, previously this was fixed to 16 bytes which is quite low.
  • Fix close issue where a handler receives a close frame so exits and then sends the responding the close frame. Previously it would then wait for a response. Fixed this by changing the closed boolean into an enum that details the close state, this catches if we have received a close frame already

Fixes an issue where the handler would wait for a close frame even though it has already received one
@adam-fowler adam-fowler merged commit 505d324 into main Apr 17, 2024
3 of 4 checks passed
@adam-fowler adam-fowler deleted the min-frame-to-compress branch April 17, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants