Return close code from WebSocketClient.run/connect #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adam-fowler
commented
Apr 17, 2024
adam-fowler
commented
- Return close code from WebSocketHandler. This is ignored by the server but passed back to the user when using the client
- Also throw errors, caused by closing WebSocket channel, Server should report these but otherwise ignore them. Client throws them
Joannis
reviewed
Apr 17, 2024
| @@ -186,14 +187,14 @@ extension WebSocketClient { | |||
| /// - eventLoopGroup: EventLoopGroup to run WebSocket client on | |||
| /// - logger: Logger | |||
| /// - process: Closure handling webSocket | |||
| public static func connect( | |||
| @discardableResult public static func connect( | |||
There was a problem hiding this comment.
Let's document the return here e.g. when it's nil
| @@ -112,7 +113,7 @@ public struct WebSocketClient { | |||
| #endif | |||
|
|
|||
| /// Connect and run handler | |||
| public func run() async throws { | |||
| @discardableResult public func run() async throws -> WebSocketErrorCode? { | |||
|
@Joannis this has had some minor changes
|
Joannis
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.