Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run router before any middleware #156

Merged
merged 5 commits into from
Jan 16, 2023
Merged

Conversation

adam-fowler
Copy link
Member

@adam-fowler adam-fowler commented Jan 8, 2023

  • When adding routes it constructs the middleware chain for the router at that point
  • Add NotFoundResponder which is called along with middleware chain when no route is found
  • Split TrieRouter into two, the builder and the responder
  • EndpointResponder returns the responder for a method, instead of calling the responder
  • Collapsed the builder part of TrieRouter into HBRouterBuilder

Split TrieRouter into two, the builder and the responder
EndpointResponder returns the responder for a method, instead of calling the responder
Collapsed the builder part of TrieRouter into HBRouterBuilder
@adam-fowler adam-fowler merged commit 3db5d72 into main Jan 16, 2023
@adam-fowler adam-fowler deleted the feature/run-router-first branch January 16, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant