Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for .env parsing (#188) #189

Merged
merged 3 commits into from
Apr 29, 2023

Conversation

sliemeobn
Copy link
Contributor

strengthened .env parsing
fixes #188

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (661a18f) 84.66% compared to head (5801967) 84.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   84.66%   84.67%           
=======================================
  Files          77       77           
  Lines        4520     4521    +1     
=======================================
+ Hits         3827     3828    +1     
  Misses        693      693           
Impacted Files Coverage Δ
Sources/Hummingbird/Environment.swift 89.13% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adam-fowler
Copy link
Member

You need to run ./script/validate.sh to get formatting correct.

@sliemeobn
Copy link
Contributor Author

You need to run ./script/validate.sh to get formatting correct.

sorry, did not get that - should be fine now...

@adam-fowler adam-fowler merged commit 4a04e53 into hummingbird-project:main Apr 29, 2023
8 of 9 checks passed
@sliemeobn sliemeobn deleted the fix/env-parsing branch May 2, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.env file parsing fails with #comments before an empty line
2 participants