Make adding middleware a requirement of RouterMethods #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Means Router, RouterGroup and RouteCollection all have the same interface. Also made it more explicit that adding a middleware wiil only be applied to routes added after. This should be consistent across the three types.
Joannis
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Means Router, RouterGroup and RouteCollection all have the same interface. Also made it more explicit that adding a middleware wiil only be applied to routes added after. This should be consistent across the three types.
Given this add
Router.add(middleware:)I could remove access to theRouter.middlewaresbut I think that is probably a move too far