Skip to content

Commit

Permalink
Merge pull request #103 from hummingbot/fix/papertrade-not-rendering
Browse files Browse the repository at this point in the history
Fix/papertrade not rendering
  • Loading branch information
cardosofede committed Dec 1, 2023
2 parents 16acd78 + b17798a commit d1b5ee4
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
14 changes: 10 additions & 4 deletions utils/data_manipulation.py
Expand Up @@ -242,13 +242,19 @@ def total_orders(self):

@property
def average_buy_price(self):
average_price = (self.buys["price"] * self.buys["amount"]).sum() / self.total_buy_amount
return average_price
if self.total_buy_amount != 0:
average_price = (self.buys["price"] * self.buys["amount"]).sum() / self.total_buy_amount
return np.nan_to_num(average_price, nan=0)
else:
return 0

@property
def average_sell_price(self):
average_price = (self.sells["price"] * self.sells["amount"]).sum() / self.total_sell_amount
return average_price
if self.total_sell_amount != 0:
average_price = (self.sells["price"] * self.sells["amount"]).sum() / self.total_sell_amount
return np.nan_to_num(average_price, nan=0)
else:
return 0

@property
def price_change(self):
Expand Down
4 changes: 2 additions & 2 deletions utils/database_manager.py
Expand Up @@ -146,7 +146,7 @@ def get_orders(self, config_file_path=None, start_date=None, end_date=None):
with self.session_maker() as session:
query = self._get_orders_query(config_file_path, start_date, end_date)
orders = pd.read_sql_query(text(query), session.connection())
orders["market"] = orders["market"].apply(lambda x: x.lower().replace("_papertrade", ""))
orders["market"] = orders["market"]
orders["amount"] = orders["amount"] / 1e6
orders["price"] = orders["price"] / 1e6
orders['creation_timestamp'] = pd.to_datetime(orders['creation_timestamp'], unit="ms")
Expand All @@ -172,7 +172,7 @@ def get_trade_fills(self, config_file_path=None, start_date=None, end_date=None)
trade_fills["gross_pnl"] = trade_fills.groupby(groupers)["realized_trade_pnl"].diff()
trade_fills["trade_fee"] = trade_fills.groupby(groupers)["cum_fees_in_quote"].diff()
trade_fills["timestamp"] = pd.to_datetime(trade_fills["timestamp"], unit="ms")
trade_fills["market"] = trade_fills["market"].apply(lambda x: x.lower().replace("_papertrade", ""))
trade_fills["market"] = trade_fills["market"]
trade_fills["quote_volume"] = trade_fills["price"] * trade_fills["amount"]
return trade_fills

Expand Down

0 comments on commit d1b5ee4

Please sign in to comment.