Refactor arbitrum_one to arbitrum #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikspz
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
- Test performed:
- Cloned and install feature branch and latest development
- connected uniswap_ethereum_arbitrum
- checked balance successfully
- created/started amm_arb strategy using arbitrum
- Review profitability rates showing
- checked order exectuion is okay
- Ran amm_data_feed_example using uniswap_ethereum_arbitrum successfully
NOTE: There're also ARBITRUM_ONE left in the node_modules folders, is it needed to change to arbitrum too as well? @fengtality
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
"refactor/": Changes made on all references from arbitrum_one chain to arbitrum due to Bug: Value error due to underscore in arbitrum_one#173
"refactor/": /home/gateway/conf/lists/arbitrum_one_coingecko_20230610.json to /home/gateway/conf/lists/arbitrum_coingecko_20230610.json
Tests performed by the developer:
Setup latest development client and gateway
Setup gateway config pangolin_avalanche_avalanche
setup gateway config uniswap_avalanche_arbitrum
Setup connector-token command and add USDC.e
Setup amm-arb with avalanche or uniswap arbitrum connector
Tips for QA testing:
Use uniswap_ethereum_arbitrum instead of georli when running AMM scripts found on ./scripts folder