Feat/pancake swap v3 #247

vic-en · 2023-12-03T03:18:01Z

Before submitting this PR, please make sure:

Your code builds clean without any errors or warnings
You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Add LP to Pancakeswap

Tests performed by the developer:

Curl test
Unit test
End-to-end testing with uniswapLp strategy on the client

Tips for QA testing:

Test as you would test uniswapLP, but replacing chain with binance-smart-chain and network with mainnet.

…nto feat/pancake_swap_v3

fengtality · 2023-12-04T02:41:34Z

@vic-en this PR introduces bad changes to yarn.lock like this:

"@ethersproject-xdc/address" "file:../../.cache/yarn/v6/npm-@ethersproject-xdc-abi-5.7.0-c99fb10e-6e34-4123-a945-38973cd5bd96-1701573291698/node_modules/@ethersproject-xdc/address"
    "@ethersproject-xdc/bignumber" "file:../../.cache/yarn/v6/npm-@ethersproject-xdc-abi-5.7.0-c99fb10e-6e34-4123-a945-38973cd5bd96-1701573291698/node_modules/@ethersproject-xdc/bignumber"
    "@ethersproject-xdc/bytes" "file:../../.cache/yarn/v6/npm-@ethersproject-xdc-abi-5.7.0-c99fb10e-6e34-4123-a945-38973cd5bd96-1701573291698/node_modules/@ethersproject-xdc/bytes"
    "@ethersproject-xdc/constants" "file:../../.cache/yarn/v6/npm-@ethersproject-xdc-abi-5.7.0-c99fb10e-6e34-4123-a945-38973cd5bd96-1701573291698/node_modules/@ethersproject-xdc/constants"
    "@ethersproject-xdc/hash" "file:../../.cache/yarn/v6/npm-@ethersproject-xdc-abi-5.7.0-c99fb10e-6e34-4123-a945-38973cd5bd96-1701573291698/node_modules/@ethersproject-xdc/hash"
    "@ethersproject-xdc/keccak256" "file:../../.cache/yarn/v6/npm-@ethersproject-xdc-abi-5.7.0-c99fb10e-6e34-4123-a945-38973cd5bd96-1701573291698/node_modules/@ethersproject-xdc/keccak256"
    "@ethersproject-xdc/logger" "file:../../.cache/yarn/v6/npm-@ethersproject-xdc-abi-5.7.0-c99fb10e-6e34-4123-a945-38973cd5bd96-1701573291698/node_modules/@ethersproject-xdc/logger"
    "@ethersproject-xdc/properties" "file:../../.cache/yarn/v6/npm-@ethersproject-xdc-abi-5.7.0-c99fb10e-6e34-4123-a945-38973cd5bd96-1701573291698/node_modules/@ethersproject-xdc/properties"
    "@ethersproject-xdc/strings" "file:../../.cache/yarn/v6/npm-@ethersproject-xdc-abi-5.7.0-c99fb10e-6e34-4123-a945-38973cd5bd96-1701573291698/node_modules/@ethersproject-xdc/strings"

I spent some time fixing development a few days ago for this issue, so please remove these changes

vic-en · 2023-12-04T18:52:37Z

@fengtality I'll do that soon.
Curious to know what issue it caused.
I noticed that change when I updated the typescript version inthe package.json file which is required by the pancake dependency.

vic-en · 2023-12-05T22:51:30Z

@fengtality @nikspz @rapcmia
I updated the yarn lock. Review can continue.

rapcmia

Setup this PR with latest development client
Pancakeswap LP must be tested on BSC mainnet
API test using Thunderclient
- GET/port ok
- GET/Wallet ok
- POST/add ok
- GET/connectors ok
API test using Curl
- curl -s -X GET -k --key $GATEWAY_KEY --cert $GATEWAY_CERT https://localhost:15888/ | jq ok
- curl -s -X GET -k --key $GATEWAY_KEY --cert $GATEWAY_CERT https://localhost:15888/chain/status | jq ok
- curl -s -X POST -k --key $GATEWAY_KEY --cert $GATEWAY_CERT -H "Content-Type: application/json" -d "$(envsubst < ./requests/add_bsc_key.json)" https://localhost:15888/wallet/add | jq ok
- curl -s -X POST -k --key $GATEWAY_KEY --cert $GATEWAY_CERT -H "Content-Type: application/json" -d "$(envsubst < ./requests/bsc_balances.json)" https://localhost:15888/chain/balances | jq ok
- curl -s -X POST -k --key $GATEWAY_KEY --cert $GATEWAY_CERT -H "Content-Type: application/json" -d "$(envsubst < ./requests/eth_uniswap_add_liquidity.json)" https://localhost:15888/amm/liquidity/add | jq ok
- curl -s -X POST -k --key $GATEWAY_KEY --cert $GATEWAY_CERT -H "Content-Type: application/json" -d "$(envsubst < ./requests/eth_uniswap_position.json)" https://localhost:15888/amm/liquidity/remove | jq ok

Ran tests using uniswap_v3_lp

Token approved for WBNB and CAKE
Liquidity added on position successfully
- When a position is closed, strategy proceeds with creating one again
- Stop strategy and start again, retrieve the active position from pancakeswapLP
- Stop and exit the client. Open, import and start strategy, successfully retrieved position with exact ID

rapcmia · 2023-12-08T12:45:00Z

Hi @vic-en github checks are still failing after 3/3 reruns 🙇🏼

vic-en · 2023-12-11T14:39:16Z

@rapcmia I'm still finding a good solution to the issue causing the workflow to fail.
I'll let you know as soon as I have something that works.
Thanks.

fengtality · 2023-12-13T00:11:32Z

@vic-en Don't worry about the workflow issues, as they appear to be related to the XRP chain and connector. I'll exclude them from the standard tests.

jellebuth · 2023-12-13T05:50:38Z

I ran a test for fetching the trading prices of a pool and the new codebase does not seem to fetch the prices from a V3 pool correctly.

Steps to replicate:

Set UseRouter -> True
Fetch price of ARV/WBNB pool for 1 ARV
Compare price with Pancakeswap interface (this should show a difference)
Customise the routing on Pancakeswap to only include V2 pools

5. Fetch price of ARV/WBNB pool for 1 ARV 6. Compare prices between PCS interface and Gateway price response (this should show a minimal difference)

Am I missing any steps in retrieving V3 prices compared to only V2 prices of a token?

In addition, I was unable to fetch prices for RITE/USDT V3 pool.

https://www.geckoterminal.com/bsc/pools/0x9b36e5b07eab82cd861aeb282235b95ee029164d

nikspz · 2023-12-14T09:10:17Z

@jellebuth
Changed rate_oracle_source to gate_io, seems able to get the price

gw247.zip

jellebuth · 2023-12-14T09:24:55Z

@nikspz

I was trying to get it for RITE (which only has a V3 Pool. But it returns that there is no pool for RITE.

https://www.geckoterminal.com/bsc/pools/0x9b36e5b07eab82cd861aeb282235b95ee029164d

I think that the price fetching feature does not have a V3 integration yet? If I look at the source code, it seems like the function that returns the price does not follow similar logic as the one for Uniswap (which does have a V3 integration).

But I might be wrong in this.

nikspz · 2023-12-14T13:16:56Z

I think that the price fetching feature does not have a V3 integration yet? If I look at the source code, it seems like the function that returns the price does not follow similar logic as the one for Uniswap (which does have a V3 integration).

But I might be wrong in this.

@vic-en Could you please check this comment?

nikspz · 2023-12-14T13:57:55Z

I was trying to get it for RITE (which only has a V3 Pool. But it returns that there is no pool for RITE.

To triage the issue, Could you confirm are you're using LP strategy /requests?
Could you please attach log/ config file as well?

vic-en · 2023-12-14T16:14:39Z

@jellebuth @nikspz
0x0F5D54b27bDb556823F96f2536496550f8816dC5, which is the token address for RITE isn't in the default Bsc mainnet token list(https://github.com/hummingbot/gateway/blob/main/src/templates/lists/bep20_tokens_mainnet.json).

So add the token and the issue shouldn't persist.

jellebuth · 2023-12-15T01:30:55Z

@vic-en @nikspz I have added this one already, but the issue persists.

@vic-en can you confirm that the V3 smart order router for price fetching is correctly integrated? And whether you are able to get the prices for the RITE-USDT V3 pool?

vic-en added 10 commits November 26, 2023 06:56

Add pancake v3

dbf6839

Update PancakeSwap contract addresses

8a58577

Update typescript version to 5.3.2

6ded875

Update UniswapLP Nft function parameter

23607e0

update Jest type declaration

2a16f04

Add 'pancakeswapLP' as a valid spender

e9da133

Update ttl value in pancakeswap.yml

15dea28

add unit tests

d9e13ac

Merge branch 'development' of https://github.com/hummingbot/gateway i…

cadf835

…nto feat/pancake_swap_v3

update yarn lock

cf2b05b

vic-en mentioned this pull request Dec 3, 2023

Vic en feat/pancake swap v3 #244

Closed

2 tasks

vic-en requested a review from fengtality December 3, 2023 03:31

rapcmia requested review from rapcmia and nikspz December 4, 2023 01:45

vic-en added 2 commits December 4, 2023 19:09

revert changes to yarn lock

a1f8adf

update yarn lock

1bcf36c

rapcmia approved these changes Dec 8, 2023

View reviewed changes

fengtality approved these changes Dec 13, 2023

View reviewed changes

fengtality merged commit 6bbec30 into hummingbot:development Dec 13, 2023
2 of 3 checks passed

fengtality mentioned this pull request Dec 13, 2023

feat/Osmosis Chain/Connector #237

Closed

nikspz mentioned this pull request Dec 13, 2023

PancakeV3 connector #195

Closed

nikspz mentioned this pull request Dec 22, 2023

Sync Gateway / Gateway staging -> master for Hummingbot version 1.23.0 #258

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/pancake swap v3 #247

Feat/pancake swap v3 #247

vic-en commented Dec 3, 2023 •

edited

fengtality commented Dec 4, 2023

vic-en commented Dec 4, 2023

vic-en commented Dec 5, 2023

rapcmia left a comment

rapcmia commented Dec 8, 2023

vic-en commented Dec 11, 2023

fengtality commented Dec 13, 2023

jellebuth commented Dec 13, 2023 •

edited

nikspz commented Dec 14, 2023 •

edited

jellebuth commented Dec 14, 2023

nikspz commented Dec 14, 2023

nikspz commented Dec 14, 2023 •

edited

vic-en commented Dec 14, 2023

jellebuth commented Dec 15, 2023

Feat/pancake swap v3 #247

Feat/pancake swap v3 #247

Conversation

vic-en commented Dec 3, 2023 • edited

fengtality commented Dec 4, 2023

vic-en commented Dec 4, 2023

vic-en commented Dec 5, 2023

rapcmia left a comment

Choose a reason for hiding this comment

rapcmia commented Dec 8, 2023

vic-en commented Dec 11, 2023

fengtality commented Dec 13, 2023

jellebuth commented Dec 13, 2023 • edited

nikspz commented Dec 14, 2023 • edited

jellebuth commented Dec 14, 2023

nikspz commented Dec 14, 2023

nikspz commented Dec 14, 2023 • edited

vic-en commented Dec 14, 2023

jellebuth commented Dec 15, 2023

vic-en commented Dec 3, 2023 •

edited

jellebuth commented Dec 13, 2023 •

edited

nikspz commented Dec 14, 2023 •

edited

nikspz commented Dec 14, 2023 •

edited