feat: Added poolID as a req parameter for the mentioned routes in the issue #302 #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync gateway / staging -> master for gateway Hummingbot version 1.25.0
sync/ Gateway development -> staging
…on-to-1.26.0 fix-update-gw-version-to-1.26.0
feat / sync staging to master version 1.26.0
|
hi @webbdays, PR should be cloned from development and changes should be pointed to development branch
You could close this PR and create new or made changes here |
|
Sure. |
|
Closed since it was created from main branch (not development) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Related to #302
Added poolID as a req parameter for the mentioned routes.
Tests performed by the developer:
yarn test:unitBut some tests are failing because of adding new req param.
Yet to write unit tests for the new param.