Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]CXMM DDEX order size limit & exchange rate converter error #386

Closed
moraliang opened this issue Jun 13, 2019 · 4 comments
Closed

[BUG]CXMM DDEX order size limit & exchange rate converter error #386

moraliang opened this issue Jun 13, 2019 · 4 comments

Comments

@moraliang
Copy link
Contributor

Describe the bug
// A clear and concise description of what the bug is.
hummingbot.market.ddex.ddex_market - ERROR - Order size is less than minimum order size allowed
TypeError: adjust_token_rate() got an unexpected keyword argument 'amount'

Steps To Reproduce
// A concise description of the steps to reproduce the buggy behavior:

########################################################
###   Cross exchange market making strategy config   ###
########################################################

# The following configuations are only required for the
# cross exchange market making strategy

# Exchange and token parameters
maker_market: ddex
taker_market: idex
maker_market_symbol: WETH-DAI
taker_market_symbol: DAI_ETH

# Minimum profitability target required to place an order
# Expressed in decimals: 0.01 = 1% target profit
min_profitability: -0.001

# Maximum order size in terms of quote currency
trade_size_override: 15.00

# Maximum aggregate amount of orders in quote currency
# that are allowed at a better price than Hummingbot's
# order before Hummingbot adjusts its order and pricing
top_depth_tolerance:

- - ^.+(USDT|USDC|USDS|DAI|PAX|TUSD)$
  - 1000
- - ^.+ETH$
  - 10
- - ^.+BTC$
  - 0.5
# Have Hummingbot actively adjust/cancel orders if necessary.
# If set to true, outstanding orders are adjusted if
# profitability falls below min_profitability.
# If set to false, outstanding orders are adjusted if
# profitability falls below cancel_order_threshold.
active_order_canceling: true

# If active_order_canceling = false, this is the profitability/
# loss threshold at which to cancel the order.
# Expressed in decimals: 0.01 = 1% target profit
cancel_order_threshold: -0.5

# An amount in seconds, which is the minimum duration for any
# placed limit orders. Default value = 130 seconds.
limit_order_min_expiration: 130.0

Screenshots
// If applicable, add screenshots to help explain your problem.
Screen Shot 2019-06-12 at 5 19 31 PM

Release version
// Include your bot's version number (Can be found at the bottom left corner of your CLI).
-0.9.0 dev

Attachments
// Please attach your config file and log file to help us debug. It would be difficult for us to help you without those!
hummingbot_logs_2019-06-12-17-11-03.log

WARNING: Do NOT publish any exchange API keys or your wallet's private key. Whoever has access to them may steal your assets!

Optional: your discord username:
Optional: your ETH address: (If you want to participate in the bug bounty)

@moraliang moraliang added the bug label Jun 13, 2019
@fengtality
Copy link
Sponsor Contributor

@moraliang Did you deposit tokens into IDEX? This error typically appears when you have no inventory in the taker_market. Since the XEMM strategy caps the trade size at the total amount that is hedgeable in the taker_market, if there is no inventory there, the trade size will become 0.

Note that unlike other DEXs, you have to deposit tokens into IDEX before trading there.

@moraliang moraliang changed the title [BUG]CXMM DDEX order size limit error [BUG]CXMM DDEX order size limit & exchange rate converter error Jun 13, 2019
@veecos2
Copy link
Contributor

veecos2 commented Jun 14, 2019

I just realized that in terms of quote currency you need to specify for 0.15 ETH which is definitely more than 15 DAI. Can you retest this ?

@nkona
Copy link
Contributor

nkona commented Jun 19, 2019

Although the bug is corrected for ddex in the latest dev version, I encountered the same "TypeError: adjust_token_rate() got an unexpected keyword argument 'amount'" specifically when using radar as a taker exchange for xemm.

This occurred regardless of the maker exchange, and did not occur when radar was the maker exchange or under an arb strategy. I have checked that balances are sufficient, and it appears that other configuration settings do not influence this bug's appearance.

@veecos2
Copy link
Contributor

veecos2 commented Jun 20, 2019

Tested it and its fixed.

@veecos2 veecos2 closed this as completed Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants