Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Missing import in AvellanedaMarketMakingStrategy #5153

Merged

Conversation

mhrvth
Copy link
Contributor

@mhrvth mhrvth commented Feb 28, 2022

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Adds a missing import of the ConditionalExecutionState

Tests performed by the developer:

  • ran unit tests
  • ran the strategy with binance paper

@dennisocana
Copy link
Contributor

@JeremyKono
Copy link
Contributor

Please resolve branch conflicts in this PR @mhrvth

Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

  • Create simple Avellaneda strategy
  • Setup config using execution_time: infinite
  • Monitor order create and cancellation, all ok
  • Modify risk_factor, order_optmization and order_levels, ok
  • Ran testbot for couple of hours then check log files, all ok
  • Check trade data on history, CSV and connector's trade history, all ok

@JeremyKono JeremyKono merged commit b5c5472 into hummingbot:development Mar 16, 2022
@mhrvth mhrvth deleted the fix/avellaneda_missing_import branch May 16, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants