Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coinbase Advanced Trade - Upgrade Coinbase spot connector to the latest exchange API and connector standard #6024

Closed
MementoRC opened this issue Jan 23, 2023 · 29 comments · Fixed by #6887
Assignees
Labels
bounty coinbase enhancement Upgrade or improvement to an existing hummingbot feature P2

Comments

@MementoRC
Copy link
Sponsor Contributor

MementoRC commented Jan 23, 2023

Feature Suggestion
Update Coinbase connector. Coinbase closed its 'CoinbasePro' API and relies on the 'Advanced Trading API'.

Impact
This is likely to break the current Coinbase Pro connector

@MementoRC MementoRC added the enhancement Upgrade or improvement to an existing hummingbot feature label Jan 23, 2023
@theWebKeyGuy
Copy link

Would really like to see this done soon myself.

@nikspz nikspz added the coinbase label Apr 5, 2023
@nikspz
Copy link
Contributor

nikspz commented Apr 14, 2023

@MementoRC Do you want to work on this one?
What's the things you need to do for the refactor?

@MementoRC
Copy link
Sponsor Contributor Author

I could give it a try, I had started looking into it with the template. The Advanced Trading AP is completely new, with many methods changed/replaced. Some devs have complained on their dev forum, so I was letting the dust settle

@nikspz
Copy link
Contributor

nikspz commented May 1, 2023

hi @MementoRC Could you please add any updates here? how's it going? are you working on it/will be working on it?

@MementoRC
Copy link
Sponsor Contributor Author

Hi @nikspz , I have started the pre-work. I am progressing a bit slowly due to concurrent items on my plate.

@nikspz
Copy link
Contributor

nikspz commented May 1, 2023

Okay got it, thanks

@nikspz
Copy link
Contributor

nikspz commented May 4, 2023

Severity: P2
Bounty: 50,000 (https://hummingbot.org/maintenance/bugs/)
Rationale: Community bounty related to bronze connector (connector needs API update)

@nikspz nikspz added the P2 label May 4, 2023
@srirambandi
Copy link
Contributor

We'd like to take up this development bounty - Coinbase connector. Me and @manibandi. I have previously contributed BitMart to Hummingbot, and have a lot of experience developing connectors and strategies in private.

@nikspz
Copy link
Contributor

nikspz commented May 5, 2023

This issue was assigned to @MementoRC . Thank you for your contribution!

@srirambandi
Copy link
Contributor

Okay, no worries! Thanks!

@nikspz
Copy link
Contributor

nikspz commented May 18, 2023

Hey @MementoRC could you please update us with your progress on this Bounty?

@MementoRC
Copy link
Sponsor Contributor Author

@nikspz Most of the implementation is completed. A few details are still investigated due to gaps in their documentation and unavailability of sandbox. Currently going through the tests as pipe-cleaning.
Should I make a PR (which will fail) for early review?

@nikspz
Copy link
Contributor

nikspz commented May 18, 2023

Yea you could create a draft @MementoRC

@MementoRC
Copy link
Sponsor Contributor Author

Oh right, gonna start on it

@rapcmia rapcmia linked a pull request May 31, 2023 that will close this issue
2 tasks
@rapcmia rapcmia linked a pull request Jul 12, 2023 that will close this issue
2 tasks
@rapcmia rapcmia removed a link to a pull request Jul 12, 2023
2 tasks
@nikspz
Copy link
Contributor

nikspz commented Jul 14, 2023

This bounty will be increased to 250K HBOT since the connector need huge refactor to advanced trade v2 API

https://snapshot.org/#/hbot-ip.eth/proposal/0x62d8feacfd0b69ab37576b9dd2304f648a23216d6e48eb8d9d50ff06fe86e90c

@MementoRC
Copy link
Sponsor Contributor Author

Very nice.
Note that Coinbase is actively adding features to their API, as it's being developed (like a REST method for order book snapshot, heartbeats for websocket, new channels). This may trigger modifications to this PR
Thank you

@nikspz
Copy link
Contributor

nikspz commented Jul 24, 2023

This bounty increased to 250K HBOT according to https://snapshot.org/#/hbot-ip.eth/proposal/0x62d8feacfd0b69ab37576b9dd2304f648a23216d6e48eb8d9d50ff06fe86e90c
and since the connector need huge refactor.

@fengtality fengtality changed the title Coinbase Advanced Trading API Upgrade Coinbase spot connector Jul 27, 2023
@fengtality
Copy link
Sponsor Contributor

fengtality commented Jul 27, 2023

Description

Bounty

  • Sponsor: Hummingbot Foundation
  • Budget: Epoch 5 Budget
  • Bounty amount: 250,000 HBOT or USDC equivalnet
  • Developer portion: 100%
  • Status: Assigned to MementoRC

@MementoRC
Copy link
Sponsor Contributor Author

Note that there should be 2 Coinbase connectors: Advanced Trade and Pro (which is used by institutional investors on Coinbase Exchange accounts)
Thank you

@fengtality
Copy link
Sponsor Contributor

fengtality commented Jul 27, 2023 via email

@nikspz
Copy link
Contributor

nikspz commented Jan 23, 2024

#6458

@nikspz
Copy link
Contributor

nikspz commented Feb 28, 2024

@MementoRC
Copy link
Sponsor Contributor Author

MementoRC commented Feb 28, 2024 via email

@MementoRC
Copy link
Sponsor Contributor Author

Persona non grata?

@nikspz
Copy link
Contributor

nikspz commented Feb 29, 2024

Hello @MementoRC the reason was based on the PR changes 99 files and using (new) redundant changes that not met connector standart as mentioned above.
From this solution, unfortunately it can't be merged into HB codebase to not create a case when it's hard to maintain connector (that built not with our latest standarts).

@nikspz
Copy link
Contributor

nikspz commented Mar 7, 2024

Description

Discussed to increase bounty amount for this bounty

Bounty

  • Sponsor: Hummingbot Foundation
  • Budget: Epoch 5 Budget and Connector pots
  • Bounty amount: 450,000 HBOT
  • Developer portion: 100%
  • Status: Assigned to MementoRC

@nikspz
Copy link
Contributor

nikspz commented Mar 8, 2024

#6887

@nikspz nikspz changed the title Upgrade Coinbase spot connector Coinbase - Upgrade Coinbase spot connector to the latest exchange API and connector standard Mar 8, 2024
@nikspz nikspz changed the title Coinbase - Upgrade Coinbase spot connector to the latest exchange API and connector standard Coinbase Advanced Trade - Upgrade Coinbase spot connector to the latest exchange API and connector standard Mar 8, 2024
@nikspz nikspz linked a pull request Mar 19, 2024 that will close this issue
2 tasks
@nikspz nikspz removed a link to a pull request Mar 19, 2024
2 tasks
@nikspz
Copy link
Contributor

nikspz commented Apr 29, 2024

Thanks for your participation, the bounty has been sent to @MementoRC. The connector has been deployed on development branch and hummingbot version 1.27.0.
https://hummingbot.org/exchanges/coinbase-advanced-trade/

@nikspz nikspz closed this as completed Apr 29, 2024
@MementoRC
Copy link
Sponsor Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty coinbase enhancement Upgrade or improvement to an existing hummingbot feature P2
Projects
Status: Paid
Development

Successfully merging a pull request may close this issue.

7 participants
@fengtality @srirambandi @theWebKeyGuy @rapcmia @nikspz @MementoRC and others