-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coinbase Advanced Trade - Upgrade Coinbase spot connector to the latest exchange API and connector standard #6024
Comments
Would really like to see this done soon myself. |
@MementoRC Do you want to work on this one? |
I could give it a try, I had started looking into it with the template. The Advanced Trading AP is completely new, with many methods changed/replaced. Some devs have complained on their dev forum, so I was letting the dust settle |
hi @MementoRC Could you please add any updates here? how's it going? are you working on it/will be working on it? |
Hi @nikspz , I have started the pre-work. I am progressing a bit slowly due to concurrent items on my plate. |
Okay got it, thanks |
Severity: P2 |
We'd like to take up this development bounty - Coinbase connector. Me and @manibandi. I have previously contributed BitMart to Hummingbot, and have a lot of experience developing connectors and strategies in private. |
This issue was assigned to @MementoRC . Thank you for your contribution! |
Okay, no worries! Thanks! |
Hey @MementoRC could you please update us with your progress on this Bounty? |
@nikspz Most of the implementation is completed. A few details are still investigated due to gaps in their documentation and unavailability of sandbox. Currently going through the tests as pipe-cleaning. |
Yea you could create a draft @MementoRC |
Oh right, gonna start on it |
This bounty will be increased to |
Very nice. |
This bounty increased to |
Description
Bounty
|
Note that there should be 2 Coinbase connectors: Advanced Trade and Pro (which is used by institutional investors on Coinbase Exchange accounts) |
I think we only need support for Advanced Trade
…On Thu, Jul 27, 2023, 9:36 AM MementoRC ***@***.***> wrote:
Note that there should be 2 Coinbase connectors: Advanced Trade and Pro
(which is used by institutional investors on Coinbase Exchange accounts)
Thank you
—
Reply to this email directly, view it on GitHub
<#6024 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANWHVR7BBLNKB3HQU2RK2DXSKKKFANCNFSM6AAAAAAUEAJDNM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I'd submit that the primary deviation is in the websocket proposal. This
part is mostly reverted in my workspace.
Would it be helpful to update with that correction?
…On Wed, Feb 28, 2024, 12:33 PM nikspz ***@***.***> wrote:
- Closed the #6458 <#6458>
- unassigned Memento from bounty since connector since pr doesn't met
our connector v2.1 standart
<https://hummingbot.org/developers/connectors/spot-connector-checklist/#directory-setup>
- could read comment related there #6458
<#6458>
—
Reply to this email directly, view it on GitHub
<#6024 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWGZEZ4POISLKMEKOHVKFS3YVYRHBAVCNFSM6AAAAAAUEAJDNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRZGU4TMNRSGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Persona non grata? |
Hello @MementoRC the reason was based on the PR changes 99 files and using (new) redundant changes that not met connector standart as mentioned above. |
Description
Discussed to increase bounty amount for this bounty Bounty
|
Thanks for your participation, the bounty has been sent to @MementoRC. The connector has been deployed on development branch and hummingbot version 1.27.0. |
Thank you |
Feature Suggestion
Update Coinbase connector. Coinbase closed its 'CoinbasePro' API and relies on the 'Advanced Trading API'.
Impact
This is likely to break the current Coinbase Pro connector
The text was updated successfully, but these errors were encountered: