Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mexc - Failed to cancel order <order id> appears when partial fills happened #6667

Closed
leetjoy opened this issue Nov 20, 2023 · 17 comments
Closed
Assignees

Comments

@leetjoy
Copy link

leetjoy commented Nov 20, 2023

Describe the bug

There is an issue observed with MEXC connector, if the order was partially filled and Humming bot canceled it - then it cannot fetch status update on this order.

Failed to cancel order <order id> error appears in log
Error fetching status update for the lost order ... Partially Cancelled

I would appreciate if anyone can fix it.
MEXC is growing exchange and connector deserves to be GOLD :)

Steps to reproduce

  1. connect to MEXC
  2. using pure_market_making create some orders on any paid
  3. wait when one of order will be partially filled and bot will attempt to cancel it
  4. -> here comes the error

Release version

1.21.0

Type of installation

Docker

Attach required files

logs_MM_JOY_test.log

@leetjoy leetjoy added the bug label Nov 20, 2023
@cardosofede
Copy link
Contributor

@rapcmia @fengtality @nikspz I talked with @leetjoy and he wants to fund this bounty. I think that has to be considered as P2 and the solution should include:

  • cancel order method --> Review how the order is processed when sending the cancelation. (specially when having partial fills)
  • evaluate the solution proposed in this PR https://github.com/hummingbot/hummingbot/pull/6584/files for the methods:
    _is_order_not_found_during_status_update_error
    _is_order_not_found_during_cancelation_error

Once the connector solution is ready we have to validate it by running a bot for > 1 day without issues

@nikspz
Copy link
Contributor

nikspz commented Nov 21, 2023

https://hummingbot.org/bounties/sponsors/
Okay, then to validate this as P2 Bounty (50k HBOT) it should be funded with 55k HBOT (50k +10%) or 133USDC (111 USDC +20%) using these wallets:
https://hummingbot.org/bounties/sponsors/#foundation-bounty-wallets

@nikspz nikspz changed the title Mexc Connector Bug Report Mexc - Failed to cancel order <order id> appears when partial fills happened Nov 22, 2023
@leetjoy
Copy link
Author

leetjoy commented Nov 22, 2023

@nikspz can I fund this bounty by sending USDC from CEX?

@nikspz
Copy link
Contributor

nikspz commented Nov 22, 2023

@leetjoy For BEP20, 0xE517b826a26B439eCE92f3220628eC007049d915 can be used for USDC.
https://hummingbot.org/bounties/sponsors/#foundation-bounty-wallets
image

@nikspz
Copy link
Contributor

nikspz commented Nov 27, 2023

hi @leetjoy Are you still willing to fund the bounty?

@leetjoy
Copy link
Author

leetjoy commented Nov 27, 2023

hi @leetjoy Are you still willing to fund the bounty?

Yes, it will be paid in 48 hours.

@leetjoy
Copy link
Author

leetjoy commented Nov 29, 2023

hi @leetjoy Are you still willing to fund the bounty?

bounty funded
tx: 0xf3868f71b20055aadc03a1c136f7f9c670b3b38367fe513091aff1a9b969f14e

@nikspz
Copy link
Contributor

nikspz commented Nov 29, 2023

Severity: P2
Bounty: 111 USDC (Developer portion)
Rationale:

  • Related to the MEXC exchange connector issue
  • MEXC connector fails to fetch status updates for partially filled and canceled orders, resulting in log errors
  • Please read issue description as the reference

@nikspz
Copy link
Contributor

nikspz commented Nov 29, 2023

Bounty Opened for developers who want to be assigned

@cardosofede
Copy link
Contributor

@yancong001 this might be of your interest

@yancong001
Copy link
Contributor

ok, i will fix this bug

@yancong001
Copy link
Contributor

here #6691

@rapcmia
Copy link
Contributor

rapcmia commented Jan 2, 2024

Fix has been deployed to release version 1.23.0

@rapcmia rapcmia closed this as completed Jan 2, 2024
@leetjoy
Copy link
Author

leetjoy commented Jan 2, 2024

thank you guys, will test this out.

@nikspz
Copy link
Contributor

nikspz commented Jan 17, 2024

Thanks for your participation, the bounty has been sent to @yancong001 . The fix has been deployed on development branch and hummingbot version 1.23.0.

@leetjoy
Copy link
Author

leetjoy commented Jan 26, 2024

@nikspz

how to update to version 1.23?

@nikspz
Copy link
Contributor

nikspz commented Jan 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Paid
Development

No branches or pull requests

5 participants