Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/ MEXC - partially canceled error #6691

Conversation

yancong001
Copy link
Contributor

@yancong001 yancong001 commented Nov 30, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

add new order status(partially canceled)

Tests performed by the developer:

Tips for QA testing:

@nikspz nikspz changed the title fix partially canceled error fix/ MEXC - partially canceled error Nov 30, 2023
Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

  • Cloned and installed fix branch
  • Created/started MEXC using high liquid token, successfully ran for a day, no partial fills
  • Created/started pureMM strategy using MEXC spot and low liquidity token
  • Review longterm bot had partial fills instances
  • After partial fills bot had instances of Failed to cancel order, however was able to recover shortly, not flooded/stuck on the order cancellation
  • Was able to run pureMM bot, handled partial fills successfully

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cardosofede cardosofede merged commit ee2c5bf into hummingbot:development Dec 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants