Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/ inventory skew divide zero bug #1293

Merged
merged 2 commits into from Jan 8, 2020
Merged

fix/ inventory skew divide zero bug #1293

merged 2 commits into from Jan 8, 2020

Conversation

chowryan
Copy link
Contributor

@chowryan chowryan commented Jan 8, 2020 •
edited

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/", etc)

Optional:

A description of the changes proposed in the pull request:

@chowryan chowryan changed the base branch from master to development January 8, 2020 22:53
yzhang1994
yzhang1994 approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@yzhang1994 yzhang1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jenkins-coinalpha
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins-hb.coinalpha.com/ghprb/job/hb-test_pull-request/1863/

@jenkins-coinalpha
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins-hb.coinalpha.com/ghprb/job/hb-test_pull-request/1864/

@jenkins-coinalpha
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins-hb.coinalpha.com/ghprb/job/hb-test_pull-request/1865/

@chowryan chowryan merged commit d9b11ca into development Jan 8, 2020
@chowryan chowryan deleted the fix_inventory_skew_divide_zero branch January 8, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhang1994 yzhang1994 yzhang1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chowryan @jenkins-coinalpha @yzhang1994