-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/remove duplicated property in PMM strategy #4922
fix/remove duplicated property in PMM strategy #4922
Conversation
Hello @29Takuya The Hummingbot Foundation just started the governance process for the community to approve or reject Pull Requests through Pull Request Proposals. For more information about how PRP votes work, check this page: https://hummingbot.org/governance/prp/ We want to know if you still have interest in having your Pull Request merged into the main codebase. If so, please check the following on your Pull Request for our team to be able to open it for community voting:
If you have any questions or need any help, feel free to reach us out on the #dev-general channel on our Discord (https://discord.gg/HAgZ79nzU4) If you have no interest in merging this PR to our code-base or don't reply to this comment in 30 days, the Foundation team will close this PR. You can still create a new PR any time you want! Thank you for contributing to Hummingbot Client! |
d4b46fd
to
aab4d00
Compare
Hi @phbrgnomo, Thank you for letting me know about the new governance process! I confirmed that three out of four points are satisfied:
It seems that GitHub checks don't run on this PR since I am a first-time contributor. |
Since this was your first PR, i hade to manually start the tests. Check back later to see if all of them passed. |
Thank you! I confirmed that all checks have passed. |
@29Takuya Takuya did you create a PRP or I can create one for you |
@RobHBOT Sorry, not yet. Could you create it on my behalf? |
Hi @29Takuya, are you still willing to work on this PR? |
Hi @JeremyKono, I am willing to work on this. Would it be possible for you to share what I need to merge this PR? |
@29Takuya this are the new contribution guidelines https://hummingbot.org/developers/contributions/ |
5875eb2
to
5452bc4
Compare
@cardosofede Thank you for your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Need to update with latest dev branch changes and good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filled order delay not affected, need to update with latest dev branch and good to go
5452bc4
to
096bb24
Compare
@cardosofede @nikspz Thank you for your reviews! I updated this PR with the latest dev branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filled order delay not affected
LGTM
In behalf of Foundation team we merged this PR to development for the upcoming Hummingbot version 1.12.0 |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
I found that property and setter of
filled_order_delay
are doubly defined inpure_market_making.pyx
.Tests performed by the developer:
Tips for QA testing: