fix/trade fill CSV export columns #5078
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
PR created to solve the issue #5057
Change in the markets recorder to use a fixed list of fields from the TradeFill object to include in the export file, instead of determining it dynamically based on the content of each trade fill.
Tests performed by the developer:
Added unit tests to check the list of fields to export is the expected one, and that the fields' content can be accessed without problems.
Manually tested by running a PMM strategy connected with Binance.
Tests performed:
Tips for QA testing:
The scenario can be reproduced following the description of the original issue.
This PR comes from CoinAlpha#68
Fixes #5057