Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP-4 Part 1: Add a Curve connector for Ethereum to Gateway #5334

Conversation

james-hummingbot
Copy link
Contributor

@james-hummingbot james-hummingbot commented May 23, 2022

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Vendorize the curve-js library and make changes necessary in order for it to work with Infura and gateway
  • Create the curve connector and make it usable via the amm routes
  • Add a condition to hummingbot that assumes Curve allowances are infinite. curve-js handles allowances internally when it performs trades.

Tests performed by the developer:

Tips for QA testing:

Curve can only be tested on the mainnet. You can test with WETH and USDT or any pairs that you see here (excluding ETH): https://curve.fi/pools

@james-hummingbot
Copy link
Contributor Author

@JeremyKono I will test on polygon then notify you guys.

@JeremyKono
Copy link
Contributor

Hi @james-hummingbot, what's the update on this PR?

@james-hummingbot
Copy link
Contributor Author

@JeremyKono I'll try to have it ready this week.

@james-hummingbot
Copy link
Contributor Author

james-hummingbot commented Oct 24, 2022

@Faouzijedidi1 @cardosofede Have you guys seen these errors before?

James added 3 commits October 24, 2022 23:31
…into feat/hip-4-1-curve-ethereum-connector
…mes-hummingbot/hummingbot into feat/hip-4-1-curve-ethereum-connector
@james-hummingbot
Copy link
Contributor Author

@Faouzijedidi1 @cardosofede
Specifically these errors: Cannot find module @uniswap. Not sure what causes that.
I will fix the curve related ones.

@james-hummingbot
Copy link
Contributor Author

I need to increase the code coverage

@james-hummingbot
Copy link
Contributor Author

@Faouzijedidi1 @cardosofede
Hey guys, I sort of forgot about this. Do think this is something the community cares about much?

@fengtality
Copy link
Sponsor Contributor

Hummingbot Foundation is opening up this bounty for pickup by a qualified community developer. There is 200K HBOT reserved for this bounty.

Original dev @james-hummingbot says that maintaining this connector requires keeping the curvejs fork up to date which is required because they hardcode some settings, so it requires a maintainer willing to keep it updated. James can give them a few pointers.

Interested devs should DM their qualifications (XP with JS and blockchain dev) to me.

@fengtality
Copy link
Sponsor Contributor

Gateway is now in a standalone repo, so the dev that picks up the Curve bounty should create a PR on that repo: https://github.com/hummingbot/gateway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants