General improvements to gateway #5381

james-hummingbot · 2022-06-07T09:27:28Z

Before submitting this PR, please make sure:

Your code builds clean without any errors or warnings
You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Make amm_arb handle MarketOrderFailureEvent properly
Update GatewayInFlightOrder to use InFlightOrder
Include nonce expiry for each nonce tracked and nonce architecture in general
Improve ConfigManagerV2 error messages
Add more details about gateway status in hummingbot
Use autorouter for uniswap
improve output from gateway status
avoid logging /network/status calls
simplify gateway create logic when infura api key is added
make initial docker not found error less technical and scary.

Tests performed by the developer:

Tips for QA testing:
Try running hummingbot and gateway with various amm_arb strategies and exchanges.

…nce_manager (feat) Include nonce expiry in `NonceManager`

…e_client_order_tracker_v2

…at/gateway_improvement_part_1

…t test

…teway_cancel

vic-en · 2022-06-24T20:41:04Z

@rapcmia The pr is ready again.
I also caught a bug at the approval stage and fixed that as well.

Let me know if you have any other issues.

rapcmia · 2022-06-27T03:58:17Z

PR update:

Tested commit 7995641a4 and confirmed we are able to run trades for Uniswap kovan testnet now successfully
Trade data on history, CSV and Txhash for uniswap-kovan matched and all ok
Tested sushiswap-kovan and we are able to trigger no arbitrage opportunity for WETH-DAI / ETH-DAI pair

However when we are testing the trade execution for sushiswap-kovan, we are getting Error: nonce has already been used [ See: https://links.ethers.org/v5-errors-NONCE_EXPIRED which doesn't happen on uniswap-kovan when testing multiple trades. We are under the impression that its something to do with Sushiswap connector? please advise, thank you

Client logs

2022-06-27 03:18:22,968 - 261943 - hummingbot.strategy.amm_arb.amm_arb - INFO - Placing SELL order for 0.010000000000000 WETH at sushiswap_ethereum_kovan at 4197.084111000000000 price [clock=2022-06-27 03:18:22+00:00]
2022-06-27 03:18:28,811 - 261943 - hummingbot.core.gateway.gateway_http_client - INFO - An unknown error has occurred on gateway. Please send your logs to dev@hummingbot.io
2022-06-27 03:18:28,811 - 261943 - hummingbot.core.gateway.gateway_http_client - ERROR - Error on POST https://localhost:24745/amm/trade Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: nonce has already been used [ See: https://links.ethers.org/v5-errors-NONCE_EXPIRED ] (error={"reason":"processing response error","code":"SERVER_ERROR","body":"{\\"jsonrpc\\":\\"2.0\\",\\"id\\":257,\\"error\\":{\\"code\\":-32010,\\"message\\":\\"Transaction nonce is too low. Try incrementing the nonce.\\"}}","error":{"code":-32010},"requestBody":"{\\"method\\":\\"eth_sendRawTransaction\\",\\"params\\":[\\"0x02f901732a820518847866c108847866c108832dc6c0941b02da8cb0d097eb8d57a175b88c7d8b4799750680b9010438ed1739000000000000000000000000000000000000000000000000002386f26fc1000000000000000000000000000000000000000000000000000240cf47966e28bbd400000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000e1f9bd605b2d6817c86bec8ee6f5e610e253f7df0000000000000000000000000000000000000000000000000000000062b923d90000000000000000000000000000000000000000000000000000000000000002000000000000000000000000d0a1e359811322d97991e03f863a0c30c2cf029c0000000000000000000000004f96fe3b7a6cf9725f59d353f723c1bdb64ca6aac001a03f0e12de9799eefe313afd450254fc209542ecaeecb57fdce02a8448f1072a46a02ebcbe4374d7b855b3c5cc9e50667f04a9e4b12bba84e509626d4f195f167185\\"],\\"id\\":257,\\"jsonrpc\\":\\"2.0\\"}","requestMethod":"POST","url":"https://kovan.infura.io/v3/my-api-key"}, method="sendTransaction", transaction="0x02f901732a820518847866c108847866c108832dc6c0941b02da8cb0d097eb8d57a175b88c7d8b4799750680b9010438ed1739000000000000000000000000000000000000000000000000002386f26fc1000000000000000000000000000000000000000000000000000240cf47966e28bbd400000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000e1f9bd605b2d6817c86bec8ee6f5e610e253f7df0000000000000000000000000000000000000000000000000000000062b923d90000000000000000000000000000000000000000000000000000000000000002000000000000000000000000d0a1e359811322d97991e03f863a0c30c2cf029c0000000000000000000000004f96fe3b7a6cf9725f59d353f723c1bdb64ca6aac001a03f0e12de9799eefe313afd450254fc209542ecaeecb57fdce02a8448f1072a46a02ebcbe4374d7b855b3c5cc9e50667f04a9e4b12bba84e509626d4f195f167185", code=NONCE_EXPIRED, version=providers/5.6.8)\n    at Logger.makeError (/usr/src/app/node_modules/@ethersproject/logger/src.ts/index.ts:261:28)\n    at Logger.throwError (/usr/src/app/node_modules/@ethersproject/logger/src.ts/index.ts:273:20)\n    at checkError (/usr/src/app/node_modules/@ethersproject/providers/src.ts/json-rpc-provider.ts:105:16)\n    at StaticJsonRpcProvider.<anonymous> (/usr/src/app/node_modules/@ethersproject/providers/src.ts/json-rpc-provider.ts:603:20)\n    at step (/usr/src/app/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:48:23)\n    at Object.throw (/usr/src/app/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:29:53)\n    at rejected (/usr/src/app/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:21:65)\n    at processTicksAndRejections (node:internal/process/task_queues:96:5)'}
2022-06-27 03:18:28,811 - 261943 - GatewayEVMAMM - ERROR - Error submitting SELL swap order to sushiswap on kovan for 0.010000000000000 WETH-DAI 4197.084111000000000.
Traceback (most recent call last):
  File "/home/ubuntu/github/5381/hummingbot/connector/gateway_EVM_AMM.py", line 520, in _create_order
    order_result: Dict[str, Any] = await GatewayHttpClient.get_instance().amm_trade(
  File "/home/ubuntu/github/5381/hummingbot/core/gateway/gateway_http_client.py", line 403, in amm_trade
    return await self.api_request("post", "amm/trade", request_payload)
  File "/home/ubuntu/github/5381/hummingbot/core/gateway/gateway_http_client.py", line 167, in api_request
    raise e
  File "/home/ubuntu/github/5381/hummingbot/core/gateway/gateway_http_client.py", line 163, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:24745/amm/trade Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: nonce has already been used [ See: https://links.ethers.org/v5-errors-NONCE_EXPIRED ] (error={"reason":"processing response error","code":"SERVER_ERROR","body":"{\\"jsonrpc\\":\\"2.0\\",\\"id\\":257,\\"error\\":{\\"code\\":-32010,\\"message\\":\\"Transaction nonce is too low. Try incrementing the nonce.\\"}}","error":{"code":-32010},"requestBody":"{\\"method\\":\\"eth_sendRawTransaction\\",\\"params\\":[\\"0x02f901732a820518847866c108847866c108832dc6c0941b02da8cb0d097eb8d57a175b88c7d8b4799750680b9010438ed1739000000000000000000000000000000000000000000000000002386f26fc1000000000000000000000000000000000000000000000000000240cf47966e28bbd400000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000e1f9bd605b2d6817c86bec8ee6f5e610e253f7df0000000000000000000000000000000000000000000000000000000062b923d90000000000000000000000000000000000000000000000000000000000000002000000000000000000000000d0a1e359811322d97991e03f863a0c30c2cf029c0000000000000000000000004f96fe3b7a6cf9725f59d353f723c1bdb64ca6aac001a03f0e12de9799eefe313afd450254fc209542ecaeecb57fdce02a8448f1072a46a02ebcbe4374d7b855b3c5cc9e50667f04a9e4b12bba84e509626d4f195f167185\\"],\\"id\\":257,\\"jsonrpc\\":\\"2.0\\"}","requestMethod":"POST","url":"https://kovan.infura.io/v3/my-api-key"}, method="sendTransaction", transaction="0x02f901732a820518847866c108847866c108832dc6c0941b02da8cb0d097eb8d57a175b88c7d8b4799750680b9010438ed1739000000000000000000000000000000000000000000000000002386f26fc1000000000000000000000000000000000000000000000000000240cf47966e28bbd400000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000e1f9bd605b2d6817c86bec8ee6f5e610e253f7df0000000000000000000000000000000000000000000000000000000062b923d90000000000000000000000000000000000000000000000000000000000000002000000000000000000000000d0a1e359811322d97991e03f863a0c30c2cf029c0000000000000000000000004f96fe3b7a6cf9725f59d353f723c1bdb64ca6aac001a03f0e12de9799eefe313afd450254fc209542ecaeecb57fdce02a8448f1072a46a02ebcbe4374d7b855b3c5cc9e50667f04a9e4b12bba84e509626d4f195f167185", code=NONCE_EXPIRED, version=providers/5.6.8)\n    at Logger.makeError (/usr/src/app/node_modules/@ethersproject/logger/src.ts/index.ts:261:28)\n    at Logger.throwError (/usr/src/app/node_modules/@ethersproject/logger/src.ts/index.ts:273:20)\n    at checkError (/usr/src/app/node_modules/@ethersproject/providers/src.ts/json-rpc-provider.ts:105:16)\n    at StaticJsonRpcProvider.<anonymous> (/usr/src/app/node_modules/@ethersproject/providers/src.ts/json-rpc-provider.ts:603:20)\n    at step (/usr/src/app/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:48:23)\n    at Object.throw (/usr/src/app/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:29:53)\n    at rejected (/usr/src/app/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:21:65)\n    at processTicksAndRejections (node:internal/process/task_queues:96:5)'}
2022-06-27 03:18:28,816 - 261943 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1656299908.0, "order_id": "sell-WETH-DAI-1656299902968774", "order_type": "OrderType.LIMIT", "event_name": "MarketOrderFailureEvent", "event_source": "sushiswap_ethereum_kovan"}
2022-06-27 03:18:28,816 - 261943 - hummingbot.connector.client_order_tracker - INFO - Order sell-WETH-DAI-1656299902968774 has failed. Order Update: OrderUpdate(trading_pair='WETH-DAI', update_timestamp=1656299908.0, new_state=<OrderState.FAILED: 6>, client_order_id='sell-WETH-DAI-1656299902968774', exchange_order_id=None, misc_updates=None)
2022-06-27 03:18:28,816 - 261943 - hummingbot.strategy.amm_arb.amm_arb - ERROR - Order sell-WETH-DAI-1656299902968774 seems to have failed in this arbitrage opportunity. Dropping Arbitrage Proposal.  [clock=2022-06-27 03:18:28+00:00]

Docker logs:

2022-06-27 04:38:25 | info | 	Expected execution price is 4239.478856, limit price is 4197.084111000000000. | undefined
2022-06-27 04:38:28 | error | 	nonce has already been used [ See: https://links.ethers.org/v5-errors-NONCE_EXPIRED ] (error={"reason":"processing response error","code":"SERVER_ERROR","body":"{\"jsonrpc\":\"2.0\",\"id\":257,\"error\":{\"code\":-32010,\"message\":\"Transaction nonce is too low. Try incrementing the nonce.\"}}","error":{"code":-32010},"requestBody":"{\"method\":\"eth_sendRawTransaction\",\"params\":[\"0x02f901732a820518847866c108847866c108832dc6c0941b02da8cb0d097eb8d57a175b88c7d8b4799750680b9010438ed1739000000000000000000000000000000000000000000000000002386f26fc1000000000000000000000000000000000000000000000000000240cf47966e28bbd400000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000e1f9bd605b2d6817c86bec8ee6f5e610e253f7df0000000000000000000000000000000000000000000000000000000062b923d90000000000000000000000000000000000000000000000000000000000000002000000000000000000000000d0a1e359811322d97991e03f863a0c30c2cf029c0000000000000000000000004f96fe3b7a6cf9725f59d353f723c1bdb64ca6aac001a03f0e12de9799eefe313afd450254fc209542ecaeecb57fdce02a8448f1072a46a02ebcbe4374d7b855b3c5cc9e50667f04a9e4b12bba84e509626d4f195f167185\"],\"id\":257,\"jsonrpc\":\"2.0\"}","requestMethod":"POST","url":"https://kovan.infura.io/v3/my-api-key"}, method="sendTransaction", transaction="0x02f901732a820518847866c108847866c108832dc6c0941b02da8cb0d097eb8d57a175b88c7d8b4799750680b9010438ed1739000000000000000000000000000000000000000000000000002386f26fc1000000000000000000000000000000000000000000000000000240cf47966e28bbd400000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000e1f9bd605b2d6817c86bec8ee6f5e610e253f7df0000000000000000000000000000000000000000000000000000000062b923d90000000000000000000000000000000000000000000000000000000000000002000000000000000000000000d0a1e359811322d97991e03f863a0c30c2cf029c0000000000000000000000004f96fe3b7a6cf9725f59d353f723c1bdb64ca6aac001a03f0e12de9799eefe313afd450254fc209542ecaeecb57fdce02a8448f1072a46a02ebcbe4374d7b855b3c5cc9e50667f04a9e4b12bba84e509626d4f195f167185", code=NONCE_EXPIRED, version=providers/5.6.8) | Error: nonce has already been used [ See: https://links.ethers.org/v5-errors-NONCE_EXPIRED ] (error={"reason":"processing response error","code":"SERVER_ERROR","body":"{\"jsonrpc\":\"2.0\",\"id\":257,\"error\":{\"code\":-32010,\"message\":\"Transaction nonce is too low. Try incrementing the nonce.\"}}","error":{"code":-32010},"requestBody":"{\"method\":\"eth_sendRawTransaction\",\"params\":[\"0x02f901732a820518847866c108847866c108832dc6c0941b02da8cb0d097eb8d57a175b88c7d8b4799750680b9010438ed1739000000000000000000000000000000000000000000000000002386f26fc1000000000000000000000000000000000000000000000000000240cf47966e28bbd400000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000e1f9bd605b2d6817c86bec8ee6f5e610e253f7df0000000000000000000000000000000000000000000000000000000062b923d90000000000000000000000000000000000000000000000000000000000000002000000000000000000000000d0a1e359811322d97991e03f863a0c30c2cf029c0000000000000000000000004f96fe3b7a6cf9725f59d353f723c1bdb64ca6aac001a03f0e12de9799eefe313afd450254fc209542ecaeecb57fdce02a8448f1072a46a02ebcbe4374d7b855b3c5cc9e50667f04a9e4b12bba84e509626d4f195f167185\"],\"id\":257,\"jsonrpc\":\"2.0\"}","requestMethod":"POST","url":"https://kovan.infura.io/v3/my-api-key"}, method="sendTransaction", transaction="0x02f901732a820518847866c108847866c108832dc6c0941b02da8cb0d097eb8d57a175b88c7d8b4799750680b9010438ed1739000000000000000000000000000000000000000000000000002386f26fc1000000000000000000000000000000000000000000000000000240cf47966e28bbd400000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000e1f9bd605b2d6817c86bec8ee6f5e610e253f7df0000000000000000000000000000000000000000000000000000000062b923d90000000000000000000000000000000000000000000000000000000000000002000000000000000000000000d0a1e359811322d97991e03f863a0c30c2cf029c0000000000000000000000004f96fe3b7a6cf9725f59d353f723c1bdb64ca6aac001a03f0e12de9799eefe313afd450254fc209542ecaeecb57fdce02a8448f1072a46a02ebcbe4374d7b855b3c5cc9e50667f04a9e4b12bba84e509626d4f195f167185", code=NONCE_EXPIRED, version=providers/5.6.8)
    at Logger.makeError (/usr/src/app/node_modules/@ethersproject/logger/src.ts/index.ts:261:28)
    at Logger.throwError (/usr/src/app/node_modules/@ethersproject/logger/src.ts/index.ts:273:20)
    at checkError (/usr/src/app/node_modules/@ethersproject/providers/src.ts/json-rpc-provider.ts:105:16)
    at StaticJsonRpcProvider.<anonymous> (/usr/src/app/node_modules/@ethersproject/providers/src.ts/json-rpc-provider.ts:603:20)
    at step (/usr/src/app/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:48:23)
    at Object.throw (/usr/src/app/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:29:53)
    at rejected (/usr/src/app/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:21:65)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

For Pangolin and TraderJoe, we are still getting the same behavior when checking balance and running the Amm-arb strategy

Setup AMM-arb for Pangolin-Avax and still getting this error of call revert exception.. which was introduce on #5408. The strategy would not start and kept returning the same error on logs. Checked moralis.io and made user the Dapps is up running and correct moralis node API is set but getting the same error.

7995641a4.zip

james-hummingbot · 2022-06-27T11:01:51Z

@rapcmia @vic-en It looks like hummingbot was not using /nextNonce, which is the new code for the nonces. I changed it.

…CoinAlpha/hummingbot into feat/gateway_improvement_part_1

james-hummingbot · 2022-06-27T19:19:43Z

@rapcmia
@vic-en 's commits should fix the avalanche issues.

vic-en · 2022-06-27T21:05:37Z

@rapcmia Pls update to commit last commit 61deddc before testing sushiswap

nikspz · 2022-06-28T03:34:44Z

@james-hummingbot @vic-en Uniswap/Sushiswap kovan now fixed 👍

commit 61deddc

Pangolin avalanche mainnet:
Steps:

clone/install feature branch, create docker image
add moralis node API key for pangolin avalanche manually (gateway config avalanche.nodeAPIKey)
start the strategy
check the balance

Actual:
Return Error: call revert exception after start the strategy / checking balance

After restart of the bot:

vic-en · 2022-06-28T04:06:44Z

@nikspz I believe that issue is fixed. Can you test pangolin again?
Just re-run balance command on my end.

rapcmia · 2022-06-28T04:11:11Z

PR update:

Tested 61deddc
Run gateway connect uniswapLP and select kovan then enter private keys, ok

However, upon checking the logs, it would return an error of EVM_Range_AMM and when running balance command it would also have an error of Unhandled error in background task: 'binance_paper_trade'. Tried to relaunch the bot and it seems to crash all the time. The workaround is to delete and reclone the PR again

2022-06-28 03:37:31,166 - 280094 - hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: 'EVM_Range_AMM'
Traceback (most recent call last):
  File "/home/ubuntu/github/5381/hummingbot/core/utils/async_utils.py", line 9, in safe_wrapper
    return await c
  File "/home/ubuntu/github/5381/hummingbot/client/command/gateway_command.py", line 485, in _gateway_connect
    AllConnectorSettings.create_connector_settings()
  File "/home/ubuntu/github/5381/hummingbot/client/settings.py", line 303, in create_connector_settings
    type=ConnectorType[connection_spec["trading_type"]],
  File "/home/ubuntu/miniconda3/envs/hummingbot/lib/python3.8/enum.py", line 344, in __getitem__
    return cls._member_map_[name]
KeyError: 'EVM_Range_AMM'
2022-06-28 03:37:42,029 - 280094 - hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: 'binance_paper_trade'
Traceback (most recent call last):
  File "/home/ubuntu/github/5381/hummingbot/core/utils/async_utils.py", line 9, in safe_wrapper
    return await c
  File "/home/ubuntu/github/5381/hummingbot/client/command/balance_command.py", line 88, in show_balances
    all_ex_bals = await asyncio.wait_for(
  File "/home/ubuntu/miniconda3/envs/hummingbot/lib/python3.8/asyncio/tasks.py", line 483, in wait_for
    return fut.result()
  File "/home/ubuntu/github/5381/hummingbot/user/user_balances.py", line 121, in all_balances_all_exchanges
    await self.update_exchanges()
  File "/home/ubuntu/github/5381/hummingbot/user/user_balances.py", line 117, in update_exchanges
    results = await safe_gather(*tasks)
  File "/home/ubuntu/github/5381/hummingbot/core/utils/async_utils.py", line 22, in safe_gather
    return await asyncio.gather(*args, **kwargs)
  File "/home/ubuntu/github/5381/hummingbot/user/user_balances.py", line 93, in update_exchange_balance
    return await self.add_exchange(exchange_name, **api_keys)
  File "/home/ubuntu/github/5381/hummingbot/user/user_balances.py", line 71, in add_exchange
    market = UserBalances.connect_market(exchange, **api_details)
  File "/home/ubuntu/github/5381/hummingbot/user/user_balances.py", line 25, in connect_market
    trading_pairs: List[str] = gateway_connector_trading_pairs(conn_setting.name)
  File "/home/ubuntu/github/5381/hummingbot/client/settings.py", line 426, in gateway_connector_trading_pairs
    if AllConnectorSettings.get_connector_settings()[conn].uses_gateway_generic_connector() and \
KeyError: 'binance_paper_trade'

61deddc.zip

nikspz · 2022-06-28T04:13:30Z

@vic-en Upon crosschecking issue still showing
Could you try these steps?

Steps:

clone/install feature branch, create docker image, gateway generate/create
add moralis node API key for pangolin avalanche manually (gateway config avalanche.nodeAPIKey)
create amm arb strategy using pangolin avalanche
start the strategy

Actual:
Returns an Error: call revert exception after start of the strategy

my Env: AWS, Ubuntu Source
commit 61deddc

vic-en · 2022-06-28T04:33:43Z

PR update:

Tested 61deddc
Run gateway connect uniswapLP and select kovan then enter private keys, ok

However, upon checking the logs, it would return an error of EVM_Range_AMM and when running balance command it would also have an error of Unhandled error in background task: 'binance_paper_trade'. Tried to relaunch the bot and it seems to crash all the time. The workaround is to delete and reclone the PR again

2022-06-28 03:37:31,166 - 280094 - hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: 'EVM_Range_AMM'
Traceback (most recent call last):
  File "/home/ubuntu/github/5381/hummingbot/core/utils/async_utils.py", line 9, in safe_wrapper
    return await c
  File "/home/ubuntu/github/5381/hummingbot/client/command/gateway_command.py", line 485, in _gateway_connect
    AllConnectorSettings.create_connector_settings()
  File "/home/ubuntu/github/5381/hummingbot/client/settings.py", line 303, in create_connector_settings
    type=ConnectorType[connection_spec["trading_type"]],
  File "/home/ubuntu/miniconda3/envs/hummingbot/lib/python3.8/enum.py", line 344, in __getitem__
    return cls._member_map_[name]
KeyError: 'EVM_Range_AMM'
2022-06-28 03:37:42,029 - 280094 - hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: 'binance_paper_trade'
Traceback (most recent call last):
  File "/home/ubuntu/github/5381/hummingbot/core/utils/async_utils.py", line 9, in safe_wrapper
    return await c
  File "/home/ubuntu/github/5381/hummingbot/client/command/balance_command.py", line 88, in show_balances
    all_ex_bals = await asyncio.wait_for(
  File "/home/ubuntu/miniconda3/envs/hummingbot/lib/python3.8/asyncio/tasks.py", line 483, in wait_for
    return fut.result()
  File "/home/ubuntu/github/5381/hummingbot/user/user_balances.py", line 121, in all_balances_all_exchanges
    await self.update_exchanges()
  File "/home/ubuntu/github/5381/hummingbot/user/user_balances.py", line 117, in update_exchanges
    results = await safe_gather(*tasks)
  File "/home/ubuntu/github/5381/hummingbot/core/utils/async_utils.py", line 22, in safe_gather
    return await asyncio.gather(*args, **kwargs)
  File "/home/ubuntu/github/5381/hummingbot/user/user_balances.py", line 93, in update_exchange_balance
    return await self.add_exchange(exchange_name, **api_keys)
  File "/home/ubuntu/github/5381/hummingbot/user/user_balances.py", line 71, in add_exchange
    market = UserBalances.connect_market(exchange, **api_details)
  File "/home/ubuntu/github/5381/hummingbot/user/user_balances.py", line 25, in connect_market
    trading_pairs: List[str] = gateway_connector_trading_pairs(conn_setting.name)
  File "/home/ubuntu/github/5381/hummingbot/client/settings.py", line 426, in gateway_connector_trading_pairs
    if AllConnectorSettings.get_connector_settings()[conn].uses_gateway_generic_connector() and \
KeyError: 'binance_paper_trade'

61deddc.zip

You're getting this because the connection you added while testing uniswapLp connector/strategy persisted.
You need to delete or manually remove that entry in gateway_connections.json file in the client conf dir.

vic-en · 2022-06-28T04:43:46Z

@vic-en Upon crosschecking issue still showing Could you try these steps?

Steps:

clone/install feature branch, create docker image, gateway generate/create

add moralis node API key for pangolin avalanche manually (gateway config avalanche.nodeAPIKey)

create amm arb strategy using pangolin avalanche

start the strategy

Actual: Returns an Error: call revert exception after start of the strategy

my Env: AWS, Ubuntu Source commit 61deddc

@nikspz I believe some steps are missing from above. I doubt the client would be starting the custom build docker just with the steps you've given. However, I did further attempt to start a strategy with an account with less funds and definitely not blocked by the issue you're reporting.

Just an insufficient balance error which is normal in my case.
I'll also further test with an account with just enough asset.

…a/hummingbot into feat/gateway_improvement_part_1

rapcmia · 2022-06-28T09:23:43Z

@vic-en thanks for the info, there are no changes on the settings we have atm for gateway config avalanche. This has been my setup even when avalanche was working before this issue happened and made sure DApps is running on Moralis as well. Im trying to reproduce the screenshot you provided using a another test wallet but no avail.

We made sure as well the docker gateway image is created within the ./gateway folder using docker build -t coinalpha/gateway-v2-dev:name-of-image -f Dockerfile . which every commit seems to be working ok for us when testing previous issues on the PR.

I did a clean uninstall/install and made sure no docker instance is present even on .hummingbot-gateway/ folder and purge all docker images available on AWS and tested again but still getting the same error of call revert exception. Screenrecord below when testing commit e08bb61

WindowsTerminal_eFot9Lro26.mp4

james-hummingbot · 2022-06-28T11:45:02Z

@vic-en the filtering is working, but getTokenBySymbol uses the wrong value. It uses tokenList instead of _tokenMap.

…CoinAlpha/hummingbot into feat/gateway_improvement_part_1

vic-en · 2022-06-28T17:51:13Z

@rapcmia Sorry for the misunderstanding. Turned out the tokens you were testing with weren't filtered.
I fixed all now and also updated some tokenList files. Your tokens should work now.
Kindly run tests again now.

rapcmia · 2022-06-29T01:23:55Z

@vic-en Thanks for the update and no worries, we are seeing some changes on the latest commit. Test in progress

arnelhbot

Test Performed

Installed branch successfully
Generated certificate and gateway create with no issues
Connected Uniswap, Susushiswap, Pangolin Traderjoe and checked balance with no issues
Created simple AMM_Arbitrage and started strategy
Verified no arbitrage opportunity in logs
Verified filled orders and data match with history
Confirmed CSV file and txhash to match on snowtrace
Tested on Source AWS Instance and Docker Build

Daniel Tan and others added 30 commits May 3, 2022 22:20

(feat/fix) cherry-pick changes to NonceManager and fixed merge conflicts

f26502d

(test) include additional unit tests for NonceManager

a07969a

(fix) address PR comments

b6e1dfc

Merge pull request #228 from CoinAlpha/fix/include_nonce_expiry_to_no…

a102a17

…nce_manager (feat) Include nonce expiry in `NonceManager`

(refactor/fix) integrate ClientOrderTracker and fix misc issues

e6e7a46

(fix) add missing changes to OrderState

5b652b0

(test) add order life cycle unit tests for GatewayInFlightOrder

a9e908f

(fix) Decimal not JSON serializable error in to_json()

de5c4fb

Merge pull request #236 from CoinAlpha/refactor/gateway_evm_amm_to_us…

abbc8fe

…e_client_order_tracker_v2

Merge development

30ba508

Merge branch 'development' of github.com:CoinAlpha/hummingbot into fe…

2b40c90

…at/gateway_improvement_part_1

Apply isort

91a4543

Fix compile issues

e542512

(fix) fix underlying issues with GatewayEVMAMM

a71a77a

(fix) fix GatewayEVMAMMConnectorUnitTest.test_update_order_status uni…

5dd8d3f

…t test

(fix) Missing attributes for handing orders and unit tests in test_ga…

9c5036f

…teway_cancel

It compiles but does it pass the tests...

d39e950

Fix one set of nonce tests

c58ddfa

fix localstorage tests

8dce44f

Improve tests

024f5b9

Fix nonce test

a2c70c1

Update documentation

6f4f909

patchTrade is not working

8a534ce

Remove comment

5045908

uniswap v3 passes

bf274f5

fix failing test on client

75e06ae

fix breaking line on gateway

d04bd6b

add unit test to pass coverage

7444a15

generate traderjoe

e66f2f4

Apply fixes

479b3d6

Use nextNonce

230edd3

James and others added 5 commits June 27, 2022 17:57

Update fixture

c6e4230

avalanche testing

18edd73

filter token list from url

2b74a06

Merge branch 'feat/gateway_improvement_part_1' of https://github.com/…

fb89c37

…CoinAlpha/hummingbot into feat/gateway_improvement_part_1

remove check for chainId in getTokenBySymbol

224acd6

sushiswap use getNextNonce

61deddc

James added 2 commits June 28, 2022 09:25

Merge branch 'feat/gateway_improvement_part_1' of github.com:CoinAlph…

f14d0ff

…a/hummingbot into feat/gateway_improvement_part_1

Use getNextNonce for traderjoe

e08bb61

vic-en added 2 commits June 28, 2022 12:44

update token filter and file lists

d24fb35

Merge branch 'feat/gateway_improvement_part_1' of https://github.com/…

2528f70

…CoinAlpha/hummingbot into feat/gateway_improvement_part_1

arnelhbot approved these changes Jun 29, 2022

View reviewed changes

JeremyKono merged commit 4d50bfa into hummingbot:development Jun 29, 2022

This was referenced Jun 29, 2022

Epic/config management refactoring #5428

Merged

Gateway: add option to Avalanche to use dynamic gas price #5308

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

General improvements to gateway #5381

General improvements to gateway #5381

james-hummingbot commented Jun 7, 2022

vic-en commented Jun 24, 2022

rapcmia commented Jun 27, 2022 •

edited

Loading

james-hummingbot commented Jun 27, 2022

james-hummingbot commented Jun 27, 2022

vic-en commented Jun 27, 2022

nikspz commented Jun 28, 2022 •

edited

Loading

vic-en commented Jun 28, 2022 •

edited

Loading

rapcmia commented Jun 28, 2022

nikspz commented Jun 28, 2022 •

edited

Loading

vic-en commented Jun 28, 2022

vic-en commented Jun 28, 2022 •

edited

Loading

rapcmia commented Jun 28, 2022

james-hummingbot commented Jun 28, 2022

vic-en commented Jun 28, 2022

rapcmia commented Jun 29, 2022

arnelhbot left a comment

General improvements to gateway #5381

General improvements to gateway #5381

Conversation

james-hummingbot commented Jun 7, 2022

vic-en commented Jun 24, 2022

rapcmia commented Jun 27, 2022 • edited Loading

james-hummingbot commented Jun 27, 2022

james-hummingbot commented Jun 27, 2022

vic-en commented Jun 27, 2022

nikspz commented Jun 28, 2022 • edited Loading

vic-en commented Jun 28, 2022 • edited Loading

rapcmia commented Jun 28, 2022

nikspz commented Jun 28, 2022 • edited Loading

vic-en commented Jun 28, 2022

vic-en commented Jun 28, 2022 • edited Loading

rapcmia commented Jun 28, 2022

james-hummingbot commented Jun 28, 2022

vic-en commented Jun 28, 2022

rapcmia commented Jun 29, 2022

arnelhbot left a comment

Choose a reason for hiding this comment

rapcmia commented Jun 27, 2022 •

edited

Loading

nikspz commented Jun 28, 2022 •

edited

Loading

vic-en commented Jun 28, 2022 •

edited

Loading

nikspz commented Jun 28, 2022 •

edited

Loading

vic-en commented Jun 28, 2022 •

edited

Loading