-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Feat) Cosmos chain base #5658
(Feat) Cosmos chain base #5658
Conversation
…ummingbot into task/sifchain-connector
…inance/hummingbot into task/sifchain-connector
…na address param since it was causing issues
Hi @JeremyKono, I resolved the conflicts. |
Hi @webston I am sorry, can you please resolve again? It has issues again after I merged another PR |
Hi @JeremyKono, I just resolved them and updated the branch. |
@webston Could you please check current branch conflicts? It's showing again |
The |
@webston Could you please fix Failing test? |
@nikspz The tests were failing because the SSL certs couldn't be found. I saw some updates related to the SSL certs in the development branch, so I merged with it. Can you please run the workflow to see if the issue is solved? |
I think I found the issue and pushed a fix. Can you please run the workflow again? |
I solved issues related to the RPC, which were failing the workflow tests, and merged with the latest development branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
All tests are passing when I run the workflow in a private repo. @rapcmia can you please trigger a new attempt for the checks? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR merged in behalf of the foundation team. The PR will be part of the development branch and release 1.12 |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
/cosmos
and/wallet
routesTips for QA testing:
/wallet
endpoint/cosmos/balances
to get the balance of an added wallet/cosmos/poll
with a txHash to get a transaction