Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feat) Cosmos chain base #5658

Merged
merged 53 commits into from
Jan 2, 2023

Conversation

webston
Copy link
Contributor

@webston webston commented Sep 2, 2022

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Adds a Cosmos chain base that can be used to add Cosmos-based chains and connectors. We are currently developing a Sifchain connector and use this base to add Sifchain as a chain and connector.
  • Removes a Solana address param from test.base.ts because it sends a Solana address with each request even if it is used for other chains.
  • Adds support for running tests when server.unsafeDevModeWithHTTP is true.

Tests performed by the developer:

  • Manually sent HTTP requests to all /cosmos and /wallet routes
  • Ran automated tests with jest

Tips for QA testing:

  • Add a cosmos wallet through the /wallet endpoint
  • Send a POST request to /cosmos/balances to get the balance of an added wallet
  • Send a POST request to /cosmos/poll with a txHash to get a transaction
  • Run jest tests

@webston
Copy link
Contributor Author

webston commented Nov 15, 2022

Hi @webston can you please resolve conflicts in this PR? Thanks

Hi @JeremyKono, I resolved the conflicts.

@JeremyKono
Copy link
Contributor

Hi @webston I am sorry, can you please resolve again? It has issues again after I merged another PR

@webston
Copy link
Contributor Author

webston commented Nov 16, 2022

Hi @JeremyKono, I just resolved them and updated the branch.

@nikspz
Copy link
Contributor

nikspz commented Nov 21, 2022

@webston Could you please check current branch conflicts? It's showing again

@webston
Copy link
Contributor Author

webston commented Nov 21, 2022

@webston Could you please check current branch conflicts? It's showing again

Hi @nikspz, I solved the conflicts.

@webston
Copy link
Contributor Author

webston commented Nov 21, 2022

The Gateway build + unit tests workflow seems to be failing because of this - no such file or directory, open '/usr/src/app/certs/ca_cert.pem'. Do you know why it happens?

@nikspz
Copy link
Contributor

nikspz commented Dec 9, 2022

@webston Could you please fix Failing test?

@webston
Copy link
Contributor Author

webston commented Dec 11, 2022

@nikspz The tests were failing because the SSL certs couldn't be found. I saw some updates related to the SSL certs in the development branch, so I merged with it. Can you please run the workflow to see if the issue is solved?

@webston
Copy link
Contributor Author

webston commented Dec 12, 2022

I think I found the issue and pushed a fix. Can you please run the workflow again?

@webston
Copy link
Contributor Author

webston commented Dec 13, 2022

I solved issues related to the RPC, which were failing the workflow tests, and merged with the latest development branch.

Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webston
Copy link
Contributor Author

webston commented Dec 22, 2022

All tests are passing when I run the workflow in a private repo. @rapcmia can you please trigger a new attempt for the checks?

Copy link
Contributor

@Faouzijedidi1 Faouzijedidi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rapcmia rapcmia merged commit c0cfc75 into hummingbot:development Jan 2, 2023
@rapcmia
Copy link
Contributor

rapcmia commented Jan 2, 2023

PR merged in behalf of the foundation team. The PR will be part of the development branch and release 1.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants