(fix) Avellaneda status for hanging orders #5862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikspz
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Test performed:
- Cloned and installed fix branch
- Created docker image manually - successfully
- Created password and Started instance with no issues
- Created/started AvellanedaMM strategy with hanging orders enabled
- Reviewed that hanging order amount now showed correct values
- Tested on different pairs/connectors
- Longrun testbot have no issues during the run, left hanging orders according the order amount
Tested using AWS Ubuntu Docker and Source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Avellaneda strategy trimmed zeros off hanging orders original amount in
statusreportThe issue seems to be a data coherence issue when the pandas dataframe is created with a column of data with inconsistent type (in this case Decimal and float). The solution proposed is to convert to float when the row is appended
Tests performed by the developer:
Added a called to the status function to verify the issue
Confirmed that the issue was resolved with the proposal
Tips for QA testing: