-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hedge/ Fixes #5996
Hedge/ Fixes #5996
Conversation
@JeremyKono @rapcmia Can I check what is the process to get this merged now? |
Hi @leastchaos good day to you, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
In behalf of Foundation team we merged this PR to development and will be included on the next Hummingbot version 1.12.0 |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Add more info to facilitate debugging.
a. change the matching of pairs from the match by trading pair to match by base asset
b. change hedge price calculation for hedge by the amount to use mid-price instead of VWAP price.
i. This is mainly used to calculate the market price to put since hummingbot only allows limit orders. Users can still increase slippage to guarantee their trade is made.
Tests performed by the developer:
Tips for QA testing: