Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hedge/ Fixes #5996

Merged
merged 15 commits into from
Jan 18, 2023
Merged

Hedge/ Fixes #5996

merged 15 commits into from
Jan 18, 2023

Conversation

leastchaos
Copy link
Contributor

@leastchaos leastchaos commented Jan 2, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using the approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Add more info to facilitate debugging.

  1. Refactor the status screen and add more information and log
  2. fixed position name referring to True and False to ONE-WAY and HEDGE
  3. Fixed issues related to typing
  4. for hedge by amount,
    a. change the matching of pairs from the match by trading pair to match by base asset
    b. change hedge price calculation for hedge by the amount to use mid-price instead of VWAP price.
    i. This is mainly used to calculate the market price to put since hummingbot only allows limit orders. Users can still increase slippage to guarantee their trade is made.

Tests performed by the developer:

Tips for QA testing:

@leastchaos leastchaos changed the title Add logs to hedge Hedge/ Fixes Jan 4, 2023
@leastchaos
Copy link
Contributor Author

@JeremyKono @rapcmia Can I check what is the process to get this merged now?

@rapcmia
Copy link
Contributor

rapcmia commented Jan 17, 2023

Hi @leastchaos good day to you,
Apologies I may have overlooked this PR and added to the board earlier. I assume we can have this merge since its fix for community strategy however I have to confirm with the team. I will get back to you

Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rapcmia rapcmia merged commit 9ef2624 into hummingbot:development Jan 18, 2023
@rapcmia
Copy link
Contributor

rapcmia commented Jan 18, 2023

In behalf of Foundation team we merged this PR to development and will be included on the next Hummingbot version 1.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants