Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove auto approval from gateway_evm_amm #5997

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Remove auto approval from gateway_evm_amm #5997

merged 3 commits into from
Jan 6, 2023

Conversation

Faouzijedidi1
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Tests performed by the developer:

Tips for QA testing:

cardosofede
cardosofede reviewed Jan 4, 2023
View reviewed changes
Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is good, the only thing that I would like to review is if we can remove line 668.

rapcmia
rapcmia approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Tested on Uniswap arbitrum and Avalanche pangolin, all ok
  • Manually approve tokens on connector website

@fengtality fengtality merged commit 7d68fe1 into development Jan 6, 2023
@fengtality fengtality deleted the feat/remove_auto_approve branch January 6, 2023 14:12
@rapcmia rapcmia mentioned this pull request Jan 24, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardosofede cardosofede cardosofede approved these changes

@rapcmia rapcmia rapcmia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Faouzijedidi1 @cardosofede @rapcmia @fengtality