Feat/approve tokens changes #6005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync/ stg -> master
sync / development -> staging
Development
sync/ development -> staging
fix / gateway source
sync / staging -> master
This reverts commit 94291f1.
cardosofede
reviewed
Jan 11, 2023
cardosofede
requested changes
Jan 11, 2023
rapcmia
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
LGTM
- Installation source/docker, ok
- Setup simple pancakeswap-bsc on source
- Test with tokens that needs to be approved
- Confirmed tokens needs to be enabled on connector
- Run
gateway approve-token [connector] [token]- Displayed
Token XXXX approval tx is pending - Displayed
Token XXXX is approved for spending for xxxx for wallet xxxxon both log and output panel
- Displayed
- Successfully approved and amm-arb worked ok
- Test docker with pangolin-avalanche
- same test done with source, all ok
- Displayed help on
gateway approve-token -h - Test invalid tokens, getting expected error for unsupported tokens
- Execute
gateway approve-tokenwhile AMM-arb is running, successfully reproduceTokens [token] is not approved for spending. Please use manual approval.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
Tips for QA testing: