Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cex poll changes #6017

Merged
merged 13 commits into from
Jan 23, 2023
Merged

Conversation

cardosofede
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Remove the connectors that didn't meet the quorum, and change the tiers of cex.

Tests performed by the developer:
Run local test

Tips for QA testing:

@nikspz
Copy link
Contributor

nikspz commented Jan 19, 2023

Steps:

  1. Cloned and installed feature branch
  2. Start the bot instance
  3. Check connect, status commands

Actual:

  • Gold connectors are Green, Silver are grey and Bronze are Yellow
  • Connectors k2, probit_kr (Probit Korea) should be removed since it didn't reach the quorum of 100,000+ HBOT votes
  • AWS showed commands painted redon the local client itpainted yellow` when checking status, config and other commands

image
image

Is it better to change gold to yellow, silver just silver. or Just dont put colors on it?
Also I think red color on the AWS could mess up the users little bit

@nikspz
Copy link
Contributor

nikspz commented Jan 19, 2023

image

Steps:
Clone and install feature branch
Create docker image manually (docker build -t hummingbot/hummingbot:newcex -f Dockerfile . )
Create/start docker instance

Actual:
At the start bot showed warning message (related to Override Fees files)

traceback:

11:18:25 - root - Cannot find corresponding config to key liquid_buy_percent_fee_deducted_from_returns in template.
11:18:25 - root - Cannot find corresponding config to key liquid_maker_fixed_fees in template.
11:18:25 - root - Cannot find corresponding config to key liquid_maker_percent_fee in template.
11:18:25 - root - Cannot find corresponding config to key liquid_percent_fee_token in template.
11:18:25 - root - Cannot find corresponding config to key liquid_taker_fixed_fees in template.
11:18:25 - root - Cannot find corresponding config to key liquid_taker_percent_fee in template.

@rapcmia
Copy link
Contributor

rapcmia commented Jan 20, 2023

PR update:

  • Text color now displays correct on both source and docker build for WSL, AWS and Mac(m1)
    image
  • Background color for command has been fixed ✅
  • Error on corresponding config has been fixed ✅

However we would like to address that whenever we stop and change exchange, it seems it still displays the previous exchange tier. This would be fix by importing the strategy file again. Crosscheck the behavior on development branch and this only happens on the PR

Paper trade
Screenshot 2023-01-20 101243

Spot connector
Screenshot 2023-01-20 100624

Perpetual connector
Screenshot 2023-01-20 100959

Steps to reproduce:

  1. Setup simple PureMM or PerpMM strategy
  2. Start the client and notice the prompt about connector status: xxxx...
  3. Stop the client and change the connector config exchange
  4. Repeat step 4 and notice the prompt that it would display the previous connector tier
  5. Try to do Step 3 and add a number of connectors and start the bot again, it should be observe the same results
  6. By import command and start the client works as expected

@nikspz
Copy link
Contributor

nikspz commented Jan 20, 2023

@Faouzijedidi1 latest commit 442ce91

Upd: issue reproduced on development

Connector status NOT showing for GOLD, SILVER and BRONZE connector after start command
after start command Connector status showing only for paper trade connector

Steps to reproduce:

  1. clone and install latest commit 442ce91
  2. create/start simple pureMM strategy using paper trade connector (binance_paper_trade)
  3. pay attention bot showed connector status: UNKNOWN
  4. stop the bot
  5. config exchange change to Gold connector (binance) or (same for Silver or Bronze)
  6. start the bot

Actual:
Bot will show
Paper trading active: all orders are simulated and no real orders are placed
Connector status: UNKNOWN

Expected:
Bot will show actual status of the connector (Gold, Silver or Bronze)
no Paper trade warning message showed for (Gold, Silver or Bronze connectors)

P.s. Issue reproduced on latest dev 1.12.0

image


P.s. Restarted the bot: connector status for binance, then for ascendex (when changed from binance)

Connector status NOT showing for GOLD, SILVER and BRONZE connector after start command

image
image

Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Successfully install source/docker build
  • Reported issues has been fixed
  • Removed connectors: CELO, Latoken, Digifinex, BTC Markets, WazirX, Beaxy, Eve, CoinZoom and Liquid
  • Updated connector status: GOLD,SILVER and BRONZE
  • Check autocomplete lists and configs for connectors, all ok

Note: tmux can't handle Gold and Bronze connectors color (there it's Red)

@rapcmia rapcmia merged commit a29fc32 into hummingbot:development Jan 23, 2023
@rapcmia
Copy link
Contributor

rapcmia commented Jan 23, 2023

Merged the PR in behalf of Foundation team to development branch and the next Hummingbot version 1.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants