Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dev 1.13 #6040

Merged
merged 15 commits into from Jan 30, 2023
Merged

Feat/dev 1.13 #6040

merged 15 commits into from Jan 30, 2023

Conversation

fengtality
Copy link
Sponsor Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • changed version to dev-1.13
  • removed Solana and Serum code

@nikspz
Copy link
Contributor

nikspz commented Jan 30, 2023

Tests performed:

  • Cloned and installed feature branch

  • Manually created gateway-v2-master image

  • Checked serum/solana not showing on:

    • gateway list
    • gateway connect automoplete list
  • Run simple amm-arb strategy

    • Uniswap (Arbitrum and Goerli): ok
    • Pancakeswap: ok
    • Avalanche: ok
    • Perpfi: ok

    Tested using Source and Docker

@nikspz
Copy link
Contributor

nikspz commented Jan 30, 2023

Current PR pointing to the development branch, but using gateway-v2-master

Actual:
Docker tag in hummingbot/core/gateway/init.py pointing to gateway-v2-master
Expected:
If PR pointing to the development branch GATEWAY_DOCKER_TAG should be
GATEWAY_DOCKER_TAG: str = "gateway-v2-dev" if platform.machine() in {"arm64", "aarch64"} else "gateway-v2-dev"

image

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fengtality fengtality merged commit 4b0667c into development Jan 30, 2023
@fengtality fengtality deleted the feat/dev-1.13 branch January 30, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants