Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cosmetic issues directional #6104

Merged

Conversation

cardosofede
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Remove duplicated signal value in format status of advanced directional strategy.
  • Add more decimals to prices on format status for the position executor since was useless for some tokens.
  • Add final status for closed executors.

Tests performed by the developer:

Tips for QA testing:

Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests Performed:

  • Cloned and installed feature branch
  • start/ran simple_directional_strategy script, no issues showed
  • start/ran advanced_directional_strategy script successfully

Note: there's a delay before advanced strategy start to place orders to Open position, discussed that it's expected

LGTM

@nikspz nikspz merged commit 9eddb8f into hummingbot:development Feb 23, 2023
@nikspz
Copy link
Contributor

nikspz commented Feb 23, 2023

In behalf of Foundation team we merged this PR to development for the upcoming Hummingbot version 1.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants